Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: content/test/weburl_loader_mock.h

Issue 1743783002: Use WeakPtr and do not use pointer equality in WebURLLoaderMockFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Loader_URLTestHelpers
Patch Set: Rebase. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/test/weburl_loader_mock.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_TEST_WEBURL_LOADER_MOCK_H_ 5 #ifndef CONTENT_TEST_WEBURL_LOADER_MOCK_H_
6 #define CONTENT_TEST_WEBURL_LOADER_MOCK_H_ 6 #define CONTENT_TEST_WEBURL_LOADER_MOCK_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 // WebURLLoader methods: 46 // WebURLLoader methods:
47 void loadSynchronously(const blink::WebURLRequest& request, 47 void loadSynchronously(const blink::WebURLRequest& request,
48 blink::WebURLResponse& response, 48 blink::WebURLResponse& response,
49 blink::WebURLError& error, 49 blink::WebURLError& error,
50 blink::WebData& data) override; 50 blink::WebData& data) override;
51 void loadAsynchronously(const blink::WebURLRequest& request, 51 void loadAsynchronously(const blink::WebURLRequest& request,
52 blink::WebURLLoaderClient* client) override; 52 blink::WebURLLoaderClient* client) override;
53 void cancel() override; 53 void cancel() override;
54 void setDefersLoading(bool defer) override; 54 void setDefersLoading(bool defer) override;
55 void setLoadingTaskRunner(blink::WebTaskRunner*) override;
55 56
56 bool isDeferred() { return is_deferred_; } 57 bool is_deferred() { return is_deferred_; }
58 bool is_cancelled() { return !client_; }
57 59
58 void setLoadingTaskRunner(blink::WebTaskRunner*) override; 60 base::WeakPtr<WebURLLoaderMock> GetWeakPtr();
59 61
60 private: 62 private:
61 WebURLLoaderMockFactory* factory_; 63 WebURLLoaderMockFactory* factory_;
62 blink::WebURLLoaderClient* client_; 64 blink::WebURLLoaderClient* client_;
63 scoped_ptr<blink::WebURLLoader> default_loader_; 65 scoped_ptr<blink::WebURLLoader> default_loader_;
64 bool using_default_loader_; 66 bool using_default_loader_;
65 bool is_deferred_; 67 bool is_deferred_;
66 68
67 base::WeakPtrFactory<WebURLLoaderMock> weak_factory_; 69 base::WeakPtrFactory<WebURLLoaderMock> weak_factory_;
68 70
69 DISALLOW_COPY_AND_ASSIGN(WebURLLoaderMock); 71 DISALLOW_COPY_AND_ASSIGN(WebURLLoaderMock);
70 }; 72 };
71 73
72 #endif // CONTENT_TEST_WEBURL_LOADER_MOCK_H_ 74 #endif // CONTENT_TEST_WEBURL_LOADER_MOCK_H_
OLDNEW
« no previous file with comments | « no previous file | content/test/weburl_loader_mock.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698