Revert of Refactor thread_local.h's TLS Implementation to use ThreadLocalStorage

Revert of Refactor thread_local.h's TLS Implementation to use ThreadLocalStorage (patchset #2 id:60001 of https://codereview.chromium.org/1726203002/ )

Reason for revert:
Reverting to consider this leak in base_unittests and unit_tests

Leak_DefinitelyLost
8,192 bytes in 4 blocks are definitely lost in loss record 40,719 of 40,770
  operator new[](unsigned long) (m_replacemalloc/vg_replace_malloc.c:1144)
  (anonymous namespace)::ConstructTlsVector() (base/threading/thread_local_storage.cc:107)
  base::ThreadLocalStorage::StaticSlot::Set(void*) (base/threading/thread_local_storage.cc:246)
  base::ThreadLocalPointer<void>::Set(void*) (base/threading/thread_local.h:69)
50 new files were left in /tmp: Fix the tests to clean up themselves.
  base::ThreadLocalBoolean::Set(bool) (base/threading/thread_local.h:88)
  base::(anonymous namespace)::WorkerThread::ThreadMain() (base/threading/worker_pool_posix.cc:79)
  base::(anonymous namespace)::ThreadFunc(void*) (base/threading/platform_thread_posix.cc:68)
Suppression (error hash=#F6EC67ECF9CF9B28#):
  For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   fun:_Zna*
   fun:_ZN12_GLOBAL__N_118ConstructTlsVectorEv
   fun:_ZN4base18ThreadLocalStorage10StaticSlot3SetEPv
   fun:_ZN4base18ThreadLocalPointerIvE3SetEPv
   fun:_ZN4base18ThreadLocalBoolean3SetEb
   fun:_ZN4base12_GLOBAL__N_112WorkerThread10ThreadMainEv
   fun:_ZN4base12_GLOBAL__N_110ThreadFuncEPv
}

Original issue's description:
> Refactor thread_local.h's TLS Implemetation to use ThreadLocalStorage
>
> thread_local_*'s implementation of TLS was redundant with
> thread_local_storage_*'s implementation.
>
> This change reduces the number of implementations by one.
>
> BUG=588824
>
> Committed: https://crrev.com/8f0b97ae15609cee6fe67d2b0b958ef37cffb1e0
> Cr-Commit-Position: refs/heads/master@{#377774}

TBR=brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=588824
Committed: https://crrev.com/16b727d05ca23177c2292b7cbd69aee7369de932
Cr-Commit-Position: refs/heads/master@{#377927}

[robliao, 2016-02-26 18:23:17]

Created Revert of Refactor thread_local.h's TLS Implementation to use
ThreadLocalStorage

[commit-bot: I haz the power, 2016-02-26 18:25:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743693002/1

[commit-bot: I haz the power, 2016-02-26 18:29:41]

Description was changed from

==========
Revert of Refactor thread_local.h's TLS Implementation to use ThreadLocalStorage
(patchset #2 id:60001 of https://codereview.chromium.org/1726203002/ )

Reason for revert:
Reverting to consider this leak in base_unittests and unit_tests

Leak_DefinitelyLost
8,192 bytes in 4 blocks are definitely lost in loss record 40,719 of 40,770
  operator new[](unsigned long) (m_replacemalloc/vg_replace_malloc.c:1144)
  (anonymous namespace)::ConstructTlsVector()
(base/threading/thread_local_storage.cc:107)
  base::ThreadLocalStorage::StaticSlot::Set(void*)
(base/threading/thread_local_storage.cc:246)
  base::ThreadLocalPointer<void>::Set(void*) (base/threading/thread_local.h:69)
50 new files were left in /tmp: Fix the tests to clean up themselves.
  base::ThreadLocalBoolean::Set(bool) (base/threading/thread_local.h:88)
  base::(anonymous namespace)::WorkerThread::ThreadMain()
(base/threading/worker_pool_posix.cc:79)
  base::(anonymous namespace)::ThreadFunc(void*)
(base/threading/platform_thread_posix.cc:68)
Suppression (error hash=#F6EC67ECF9CF9B28#):
  For more info on using suppressions see
http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/mem...
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   fun:_Zna*
   fun:_ZN12_GLOBAL__N_118ConstructTlsVectorEv
   fun:_ZN4base18ThreadLocalStorage10StaticSlot3SetEPv
   fun:_ZN4base18ThreadLocalPointerIvE3SetEPv
   fun:_ZN4base18ThreadLocalBoolean3SetEb
   fun:_ZN4base12_GLOBAL__N_112WorkerThread10ThreadMainEv
   fun:_ZN4base12_GLOBAL__N_110ThreadFuncEPv
}

Original issue's description:
> Refactor thread_local.h's TLS Implemetation to use ThreadLocalStorage
> 
> thread_local_*'s implementation of TLS was redundant with
> thread_local_storage_*'s implementation.
> 
> This change reduces the number of implementations by one.
> 
> BUG=588824
> 
> Committed: https://crrev.com/8f0b97ae15609cee6fe67d2b0b958ef37cffb1e0
> Cr-Commit-Position: refs/heads/master@{#377774}

TBR=brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=588824
==========

to

==========
Revert of Refactor thread_local.h's TLS Implementation to use ThreadLocalStorage
(patchset #2 id:60001 of https://codereview.chromium.org/1726203002/ )

Reason for revert:
Reverting to consider this leak in base_unittests and unit_tests

Leak_DefinitelyLost
8,192 bytes in 4 blocks are definitely lost in loss record 40,719 of 40,770
  operator new[](unsigned long) (m_replacemalloc/vg_replace_malloc.c:1144)
  (anonymous namespace)::ConstructTlsVector()
(base/threading/thread_local_storage.cc:107)
  base::ThreadLocalStorage::StaticSlot::Set(void*)
(base/threading/thread_local_storage.cc:246)
  base::ThreadLocalPointer<void>::Set(void*) (base/threading/thread_local.h:69)
50 new files were left in /tmp: Fix the tests to clean up themselves.
  base::ThreadLocalBoolean::Set(bool) (base/threading/thread_local.h:88)
  base::(anonymous namespace)::WorkerThread::ThreadMain()
(base/threading/worker_pool_posix.cc:79)
  base::(anonymous namespace)::ThreadFunc(void*)
(base/threading/platform_thread_posix.cc:68)
Suppression (error hash=#F6EC67ECF9CF9B28#):
  For more info on using suppressions see
http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/mem...
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   fun:_Zna*
   fun:_ZN12_GLOBAL__N_118ConstructTlsVectorEv
   fun:_ZN4base18ThreadLocalStorage10StaticSlot3SetEPv
   fun:_ZN4base18ThreadLocalPointerIvE3SetEPv
   fun:_ZN4base18ThreadLocalBoolean3SetEb
   fun:_ZN4base12_GLOBAL__N_112WorkerThread10ThreadMainEv
   fun:_ZN4base12_GLOBAL__N_110ThreadFuncEPv
}

Original issue's description:
> Refactor thread_local.h's TLS Implemetation to use ThreadLocalStorage
> 
> thread_local_*'s implementation of TLS was redundant with
> thread_local_storage_*'s implementation.
> 
> This change reduces the number of implementations by one.
> 
> BUG=588824
> 
> Committed: https://crrev.com/8f0b97ae15609cee6fe67d2b0b958ef37cffb1e0
> Cr-Commit-Position: refs/heads/master@{#377774}

TBR=brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=588824
==========

[commit-bot: I haz the power, 2016-02-26 18:29:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-26 18:31:50]

Description was changed from

==========
Revert of Refactor thread_local.h's TLS Implementation to use ThreadLocalStorage
(patchset #2 id:60001 of https://codereview.chromium.org/1726203002/ )

Reason for revert:
Reverting to consider this leak in base_unittests and unit_tests

Leak_DefinitelyLost
8,192 bytes in 4 blocks are definitely lost in loss record 40,719 of 40,770
  operator new[](unsigned long) (m_replacemalloc/vg_replace_malloc.c:1144)
  (anonymous namespace)::ConstructTlsVector()
(base/threading/thread_local_storage.cc:107)
  base::ThreadLocalStorage::StaticSlot::Set(void*)
(base/threading/thread_local_storage.cc:246)
  base::ThreadLocalPointer<void>::Set(void*) (base/threading/thread_local.h:69)
50 new files were left in /tmp: Fix the tests to clean up themselves.
  base::ThreadLocalBoolean::Set(bool) (base/threading/thread_local.h:88)
  base::(anonymous namespace)::WorkerThread::ThreadMain()
(base/threading/worker_pool_posix.cc:79)
  base::(anonymous namespace)::ThreadFunc(void*)
(base/threading/platform_thread_posix.cc:68)
Suppression (error hash=#F6EC67ECF9CF9B28#):
  For more info on using suppressions see
http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/mem...
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   fun:_Zna*
   fun:_ZN12_GLOBAL__N_118ConstructTlsVectorEv
   fun:_ZN4base18ThreadLocalStorage10StaticSlot3SetEPv
   fun:_ZN4base18ThreadLocalPointerIvE3SetEPv
   fun:_ZN4base18ThreadLocalBoolean3SetEb
   fun:_ZN4base12_GLOBAL__N_112WorkerThread10ThreadMainEv
   fun:_ZN4base12_GLOBAL__N_110ThreadFuncEPv
}

Original issue's description:
> Refactor thread_local.h's TLS Implemetation to use ThreadLocalStorage
> 
> thread_local_*'s implementation of TLS was redundant with
> thread_local_storage_*'s implementation.
> 
> This change reduces the number of implementations by one.
> 
> BUG=588824
> 
> Committed: https://crrev.com/8f0b97ae15609cee6fe67d2b0b958ef37cffb1e0
> Cr-Commit-Position: refs/heads/master@{#377774}

TBR=brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=588824
==========

to

==========
Revert of Refactor thread_local.h's TLS Implementation to use ThreadLocalStorage
(patchset #2 id:60001 of https://codereview.chromium.org/1726203002/ )

Reason for revert:
Reverting to consider this leak in base_unittests and unit_tests

Leak_DefinitelyLost
8,192 bytes in 4 blocks are definitely lost in loss record 40,719 of 40,770
  operator new[](unsigned long) (m_replacemalloc/vg_replace_malloc.c:1144)
  (anonymous namespace)::ConstructTlsVector()
(base/threading/thread_local_storage.cc:107)
  base::ThreadLocalStorage::StaticSlot::Set(void*)
(base/threading/thread_local_storage.cc:246)
  base::ThreadLocalPointer<void>::Set(void*) (base/threading/thread_local.h:69)
50 new files were left in /tmp: Fix the tests to clean up themselves.
  base::ThreadLocalBoolean::Set(bool) (base/threading/thread_local.h:88)
  base::(anonymous namespace)::WorkerThread::ThreadMain()
(base/threading/worker_pool_posix.cc:79)
  base::(anonymous namespace)::ThreadFunc(void*)
(base/threading/platform_thread_posix.cc:68)
Suppression (error hash=#F6EC67ECF9CF9B28#):
  For more info on using suppressions see
http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/mem...
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   fun:_Zna*
   fun:_ZN12_GLOBAL__N_118ConstructTlsVectorEv
   fun:_ZN4base18ThreadLocalStorage10StaticSlot3SetEPv
   fun:_ZN4base18ThreadLocalPointerIvE3SetEPv
   fun:_ZN4base18ThreadLocalBoolean3SetEb
   fun:_ZN4base12_GLOBAL__N_112WorkerThread10ThreadMainEv
   fun:_ZN4base12_GLOBAL__N_110ThreadFuncEPv
}

Original issue's description:
> Refactor thread_local.h's TLS Implemetation to use ThreadLocalStorage
>
> thread_local_*'s implementation of TLS was redundant with
> thread_local_storage_*'s implementation.
>
> This change reduces the number of implementations by one.
>
> BUG=588824
>
> Committed: https://crrev.com/8f0b97ae15609cee6fe67d2b0b958ef37cffb1e0
> Cr-Commit-Position: refs/heads/master@{#377774}

TBR=brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=588824

Committed: https://crrev.com/16b727d05ca23177c2292b7cbd69aee7369de932
Cr-Commit-Position: refs/heads/master@{#377927}
==========

[commit-bot: I haz the power, 2016-02-26 18:31:51]

Patchset 1 (id:??) landed as
https://crrev.com/16b727d05ca23177c2292b7cbd69aee7369de932
Cr-Commit-Position: refs/heads/master@{#377927}