Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1743433002: Revert of [compiler] Drop the CompareNilIC. (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [compiler] Drop the CompareNilIC. (patchset #4 id:60001 of https://codereview.chromium.org/1722193002/ ) Reason for revert: Speculative revert in attempt to fix #2 crasher on canary. Original issue's description: > [compiler] Drop the CompareNilIC. > > Since both null and undefined are also marked as undetectable now, we > can just test that bit instead of having the CompareNilIC try to collect > feedback to speed up the general case (without the undetectable bit > being used). > > Drive-by-fix: Update the type system to match the new handling of > undetectable in the runtime. > > R=danno@chromium.org > > Committed: https://crrev.com/666aec0348c8793e61c8633dee7ad29a514239ba > Cr-Commit-Position: refs/heads/master@{#34237} TBR=danno@chromium.org,verwaest@chromium.org,bmeurer@chromium.org LOG=y BUG=chromium:589897 NOTRY=true Committed: https://crrev.com/fca68bac47897a11a8cd8d741f2153d4116578a1 Cr-Commit-Position: refs/heads/master@{#34308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -143 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +91 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 4 chunks +79 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/compiler/change-lowering.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/change-lowering.cc View 3 chunks +0 lines, -34 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 6 chunks +6 lines, -19 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +62 lines, -5 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/crankshaft/hydrogen-types.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ic/ic.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +53 lines, -0 lines 0 comments Download
M src/ic/ic-compiler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/log.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/type-info.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/types.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/types.cc View 2 chunks +17 lines, -9 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-types.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
adamk
Created Revert of [compiler] Drop the CompareNilIC.
4 years, 10 months ago (2016-02-25 23:08:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743433002/1
4 years, 10 months ago (2016-02-25 23:09:03 UTC) #4
Michael Hablich
On 2016/02/25 23:09:03, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 10 months ago (2016-02-26 00:13:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743433002/1
4 years, 10 months ago (2016-02-26 00:14:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 00:16:37 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 00:17:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fca68bac47897a11a8cd8d741f2153d4116578a1
Cr-Commit-Position: refs/heads/master@{#34308}

Powered by Google App Engine
This is Rietveld 408576698