Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 1743433002: Revert of [compiler] Drop the CompareNilIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 3823 matching lines...) Expand 10 before | Expand all | Expand 10 after
3834 VisitForAccumulatorValue(sub_expr); 3834 VisitForAccumulatorValue(sub_expr);
3835 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 3835 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
3836 3836
3837 if (expr->op() == Token::EQ_STRICT) { 3837 if (expr->op() == Token::EQ_STRICT) {
3838 Heap::RootListIndex nil_value = nil == kNullValue ? 3838 Heap::RootListIndex nil_value = nil == kNullValue ?
3839 Heap::kNullValueRootIndex : 3839 Heap::kNullValueRootIndex :
3840 Heap::kUndefinedValueRootIndex; 3840 Heap::kUndefinedValueRootIndex;
3841 __ CompareRoot(x0, nil_value); 3841 __ CompareRoot(x0, nil_value);
3842 Split(eq, if_true, if_false, fall_through); 3842 Split(eq, if_true, if_false, fall_through);
3843 } else { 3843 } else {
3844 __ JumpIfSmi(x0, if_false); 3844 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil);
3845 __ Ldr(x0, FieldMemOperand(x0, HeapObject::kMapOffset)); 3845 CallIC(ic, expr->CompareOperationFeedbackId());
3846 __ Ldrb(x1, FieldMemOperand(x0, Map::kBitFieldOffset)); 3846 __ CompareRoot(x0, Heap::kTrueValueRootIndex);
3847 __ TestAndSplit(x1, 1 << Map::kIsUndetectable, if_false, if_true, 3847 Split(eq, if_true, if_false, fall_through);
3848 fall_through);
3849 } 3848 }
3850 3849
3851 context()->Plug(if_true, if_false); 3850 context()->Plug(if_true, if_false);
3852 } 3851 }
3853 3852
3854 3853
3855 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 3854 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
3856 __ Ldr(x0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 3855 __ Ldr(x0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
3857 context()->Plug(x0); 3856 context()->Plug(x0);
3858 } 3857 }
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
4304 } 4303 }
4305 4304
4306 return INTERRUPT; 4305 return INTERRUPT;
4307 } 4306 }
4308 4307
4309 4308
4310 } // namespace internal 4309 } // namespace internal
4311 } // namespace v8 4310 } // namespace v8
4312 4311
4313 #endif // V8_TARGET_ARCH_ARM64 4312 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698