Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 174343004: Remove some weird comments that are not really necessary causing confusion. (Closed)

Created:
6 years, 10 months ago by atreat
Modified:
6 years, 10 months ago
Reviewers:
pdr., esprehn, eseidel
CC:
blink-reviews, philipj_slow, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove some weird comments that are not really necessary causing confusion. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167639

Patch Set 1 #

Patch Set 2 : Remove comments instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderMedia.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
atreat
Not sure what is wrong with the bots, but I don't think it is related.
6 years, 10 months ago (2014-02-21 19:22:52 UTC) #1
esprehn
How much of an impact LayoutState has is based on what CSS properties you use ...
6 years, 10 months ago (2014-02-21 19:30:32 UTC) #2
atreat
On 2014/02/21 19:30:32, esprehn wrote: > How much of an impact LayoutState has is based ...
6 years, 10 months ago (2014-02-21 19:39:51 UTC) #3
esprehn
On 2014/02/21 19:39:51, atreat wrote: > On 2014/02/21 19:30:32, esprehn wrote: > > How much ...
6 years, 10 months ago (2014-02-21 19:51:17 UTC) #4
atreat
On 2014/02/21 19:51:17, esprehn wrote: > On 2014/02/21 19:39:51, atreat wrote: > > On 2014/02/21 ...
6 years, 10 months ago (2014-02-21 21:41:41 UTC) #5
esprehn
lgtm
6 years, 10 months ago (2014-02-21 22:02:38 UTC) #6
atreat
The CQ bit was checked by adam.treat@samsung.com
6 years, 10 months ago (2014-02-22 17:09:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/174343004/100001
6 years, 10 months ago (2014-02-22 17:09:15 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 21:14:16 UTC) #9
Message was sent while issue was closed.
Change committed as 167639

Powered by Google App Engine
This is Rietveld 408576698