rietveld.py - Issue 174313002: Added a default timeout to rietveld requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rietveld.py

Issue 174313002: Added a default timeout to rietveld requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Addressing comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: rietveld.py

diff --git a/rietveld.py b/rietveld.py

index 5528c551a6af1278fb83b9c3413547da2cfa6709..39cb19a9d7876c692bfdb41be9a798fc270d7510 100644

--- a/rietveld.py

+++ b/rietveld.py

@@ -367,6 +367,9 @@ class Rietveld(object):

def _send(self, request_path, **kwargs):

"""Sends a POST/GET to Rietveld. Returns the response body."""

+ # rpc_server.Send() assumes timeout=None by default; make sure it's set

+ # to something reasonable.

+ kwargs.setdefault('timeout', 15)

logging.debug('POSTing to %s, args %s.', request_path, kwargs)

try:

# Sadly, upload.py calls ErrorExit() which does a sys.exit(1) on HTTP

« no previous file with comments | « no previous file | tests/rietveld_test.py » ('j') | no next file with comments »