Added a default timeout to rietveld requests.

rietveld.py

 # coding: utf-8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines class Rietveld to easily access a rietveld instance.
 
 Security implications:
 
 The following hypothesis are made:
 - Rietveld enforces:
@@ skipping 349 matching lines @@
   def get(self, request_path, **kwargs):
     kwargs.setdefault('payload', None)
     return self._send(request_path, **kwargs)
 
   def post(self, request_path, data, **kwargs):
     ctype, body = upload.EncodeMultipartFormData(data, [])
     return self._send(request_path, payload=body, content_type=ctype, **kwargs)
 
   def _send(self, request_path, **kwargs):
     """Sends a POST/GET to Rietveld.  Returns the response body."""
+    # rpc_server.Send() assumes timeout=None by default; make sure it's set
+    # to something reasonable.
+    kwargs.setdefault('timeout', 15)
     logging.debug('POSTing to %s, args %s.', request_path, kwargs)
     try:
       # Sadly, upload.py calls ErrorExit() which does a sys.exit(1) on HTTP
       # 500 in AbstractRpcServer.Send().
       old_error_exit = upload.ErrorExit
       def trap_http_500(msg):
         """Converts an incorrect ErrorExit() call into a HTTPError exception."""
         m = re.search(r'(50\d) Server Error', msg)
         if m:
           # Fake an HTTPError exception. Cheezy. :(
@@ skipping 146 matching lines @@
 
   def set_flag(self, issue, patchset, flag, value):  # pylint:disable=R0201
     logging.info('ReadOnlyRietveld: setting flag "%s" to "%s" for issue %d' %
         (flag, value, issue))
     ReadOnlyRietveld._local_changes.setdefault(issue, {})[flag] = value
 
   def trigger_try_jobs(  # pylint:disable=R0201
       self, issue, patchset, reason, clobber, revision, builders_and_tests):
     logging.info('ReadOnlyRietveld: triggering try jobs %r for issue %d' %
         (builders_and_tests, issue))