Remove EME and MSE from RuntimeEnabledFeatures.

Remove EME and MSE from RuntimeEnabledFeatures.

These are stable and no longer need to be configurable.
On Android, only Clear Key will be available when MediaCodec is unavailable.

Also removes the MSE flag and command line switch and unreferenced EME switch.

BUG=582618, 249976
Committed: https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809
Cr-Commit-Position: refs/heads/master@{#379660}

[ddorwin, 2016-02-27 01:28:24]

ddorwin@chromium.org changed reviewers:
+ wolenetz@chromium.org, xhwang@chromium.org

[ddorwin, 2016-02-27 01:28:24]

ddorwin@chromium.org changed required reviewers:
+ wolenetz@chromium.org, xhwang@chromium.org

[ddorwin, 2016-02-27 01:28:24]

I will land this after M50 is cut.

[xhwang, 2016-02-27 01:42:45]

lgtm % one question

https://codereview.chromium.org/1742933002/diff/1/content/child/runtime_featu...
File content/child/runtime_features.cc (left):

https://codereview.chromium.org/1742933002/diff/1/content/child/runtime_featu...
content/child/runtime_features.cc:37: }
So will we just reject all rMKSA calls on platforms where MediaCodec is not
available?

[ddorwin, 2016-02-27 01:49:02]

https://codereview.chromium.org/1742933002/diff/1/content/child/runtime_featu...
File content/child/runtime_features.cc (left):

https://codereview.chromium.org/1742933002/diff/1/content/child/runtime_featu...
content/child/runtime_features.cc:37: }
On 2016/02/27 01:42:45, xhwang wrote:
> So will we just reject all rMKSA calls on platforms where MediaCodec is not
> available?

For Clear Key (with the unified media pipeline), everything except H.264 should
work. I guess I should move the IsMediaCodecAvailable() there.

Since MediaDrm-based Key Systems require platform decoders (see
media::mime_util), we should check support before registering them in
KeySystems.

I'll work on this. Good catch!

[ddorwin, 2016-02-27 05:23:44]

https://codereview.chromium.org/1742933002/diff/1/content/child/runtime_featu...
File content/child/runtime_features.cc (left):

https://codereview.chromium.org/1742933002/diff/1/content/child/runtime_featu...
content/child/runtime_features.cc:37: }
On 2016/02/27 01:49:02, ddorwin wrote:
> On 2016/02/27 01:42:45, xhwang wrote:
> > So will we just reject all rMKSA calls on platforms where MediaCodec is not
> > available?
> 
> For Clear Key (with the unified media pipeline), everything except H.264
should
> work. I guess I should move the IsMediaCodecAvailable() there.
> 
> Since MediaDrm-based Key Systems require platform decoders (see
> media::mime_util), we should check support before registering them in
> KeySystems.
> 
> I'll work on this. Good catch!

I posted my thoughts in
https://bugs.chromium.org/p/chromium/issues/detail?id=582618#c7.

[wolenetz, 2016-02-29 18:20:06]

On 2016/02/27 05:23:44, ddorwin wrote:
>
https://codereview.chromium.org/1742933002/diff/1/content/child/runtime_featu...
> File content/child/runtime_features.cc (left):
> 
>
https://codereview.chromium.org/1742933002/diff/1/content/child/runtime_featu...
> content/child/runtime_features.cc:37: }
> On 2016/02/27 01:49:02, ddorwin wrote:
> > On 2016/02/27 01:42:45, xhwang wrote:
> > > So will we just reject all rMKSA calls on platforms where MediaCodec is
not
> > > available?
> > 
> > For Clear Key (with the unified media pipeline), everything except H.264
> should
> > work. I guess I should move the IsMediaCodecAvailable() there.
> > 
> > Since MediaDrm-based Key Systems require platform decoders (see
> > media::mime_util), we should check support before registering them in
> > KeySystems.
> > 
> > I'll work on this. Good catch!
> 
> I posted my thoughts in
> https://bugs.chromium.org/p/chromium/issues/detail?id=582618#c7.

MSE flag removal sgtm. I'll review in depth on my return tomorrow.

[ddorwin, 2016-03-02 21:19:28]

ddorwin@chromium.org changed reviewers:
+ achuith@chromium.org, pfeldman@chromium.org

[ddorwin, 2016-03-02 21:19:29]

https://codereview.chromium.org/1747073003/ will ensure that EME behaves
correctly. I will land that first.

pfeldman: Please OWNERS review the simple removals in content/* and the last
three WebKit files (those not in  third_party/WebKit/Source/modules/).

achuith: Please OWNERS review
chrome/browser/chromeos/login/chrome_restart_request.cc.

wolenetz: Please review third_party/WebKit/Source/modules/mediasource/*.

[wolenetz, 2016-03-03 00:21:15]

third_party/WebKit/Source/modules/mediasource/* lgtm % rebase-related question:

https://codereview.chromium.org/1742933002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/1742933002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:112: Media
status=stable
nit: rebase to ToT will remove this and the references to this, right? I assume
you're aware of https://codereview.chromium.org/1749683002 (actually, I know you
are from IM chat).

[ddorwin, 2016-03-03 00:29:16]

https://codereview.chromium.org/1742933002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/1742933002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:112: Media
status=stable
On 2016/03/03 00:21:14, wolenetz wrote:
> nit: rebase to ToT will remove this and the references to this, right? I
assume
> you're aware of https://codereview.chromium.org/1749683002 (actually, I know
you
> are from IM chat).

Yes, my work on this CL led to me asking about this, which led to its removal.
:) There are some other stable Media* features we might be able to remove too,
but someone will need to investigate whether we programmatically disable them
like we used to these features.

[ddorwin, 2016-03-04 19:43:17]

achuithb & pfeldman: Friendly ping on simple deletions.

[pfeldman, 2016-03-07 18:26:46]

lgtm

[ddorwin, 2016-03-07 19:42:19]

Description was changed from

==========
Remove EME and MSE from RuntimeEnabledFeatures.

These are stable and no longer need to be configurable.
On Android, only Clear Key will be available when MediaCodec is unavailable.

Also removes the MSE flag and command line switch and unreferenced EME switch.

BUG=582618,249976
==========

to

==========
Remove EME and MSE from RuntimeEnabledFeatures.

These are stable and no longer need to be configurable.
On Android, only Clear Key will be available when MediaCodec is unavailable.

Also removes the MSE flag and command line switch and unreferenced EME switch.

BUG=582618,249976
TBR=achuithb@chromium.org
==========

[ddorwin, 2016-03-07 19:42:55]

TBRing achuithb on a simple deletion.

[ddorwin, 2016-03-07 19:43:00]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2016-03-07 19:43:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1742933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1742933002/1

[commit-bot: I haz the power, 2016-03-07 19:47:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 19:47:20]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ddorwin, 2016-03-07 20:29:45]

The CQ bit was checked by ddorwin@chromium.org

[ddorwin, 2016-03-07 20:29:46]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
pfeldman@chromium.org, wolenetz@chromium.org
Link to the patchset: https://codereview.chromium.org/1742933002/#ps20001
(title: "rebase only")

[commit-bot: I haz the power, 2016-03-07 20:30:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1742933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1742933002/20001

[achuithb, 2016-03-07 20:37:22]

lgtm

[ddorwin, 2016-03-07 20:39:55]

Description was changed from

==========
Remove EME and MSE from RuntimeEnabledFeatures.

These are stable and no longer need to be configurable.
On Android, only Clear Key will be available when MediaCodec is unavailable.

Also removes the MSE flag and command line switch and unreferenced EME switch.

BUG=582618,249976
TBR=achuithb@chromium.org
==========

to

==========
Remove EME and MSE from RuntimeEnabledFeatures.

These are stable and no longer need to be configurable.
On Android, only Clear Key will be available when MediaCodec is unavailable.

Also removes the MSE flag and command line switch and unreferenced EME switch.

BUG=582618,249976
==========

[commit-bot: I haz the power, 2016-03-07 22:05:42]

Description was changed from

==========
Remove EME and MSE from RuntimeEnabledFeatures.

These are stable and no longer need to be configurable.
On Android, only Clear Key will be available when MediaCodec is unavailable.

Also removes the MSE flag and command line switch and unreferenced EME switch.

BUG=582618,249976
==========

to

==========
Remove EME and MSE from RuntimeEnabledFeatures.

These are stable and no longer need to be configurable.
On Android, only Clear Key will be available when MediaCodec is unavailable.

Also removes the MSE flag and command line switch and unreferenced EME switch.

BUG=582618,249976
==========

[commit-bot: I haz the power, 2016-03-07 22:05:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-07 22:07:31]

Description was changed from

==========
Remove EME and MSE from RuntimeEnabledFeatures.

These are stable and no longer need to be configurable.
On Android, only Clear Key will be available when MediaCodec is unavailable.

Also removes the MSE flag and command line switch and unreferenced EME switch.

BUG=582618,249976
==========

to

==========
Remove EME and MSE from RuntimeEnabledFeatures.

These are stable and no longer need to be configurable.
On Android, only Clear Key will be available when MediaCodec is unavailable.

Also removes the MSE flag and command line switch and unreferenced EME switch.

BUG=582618,249976

Committed: https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809
Cr-Commit-Position: refs/heads/master@{#379660}
==========

[commit-bot: I haz the power, 2016-03-07 22:07:32]

Patchset 2 (id:??) landed as
https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809
Cr-Commit-Position: refs/heads/master@{#379660}