Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 1749683002: Remove the always-enabled Media from RuntimeEnabledFeatures (Closed)

Created:
4 years, 9 months ago by philipj_slow
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, jam, kinuko+watch, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the always-enabled Media from RuntimeEnabledFeatures This has been enabled everywhere since https://codereview.chromium.org/590083002 Committed: https://crrev.com/b90a631cdd8bf933a4e935db73605796e4c5461c Cr-Commit-Position: refs/heads/master@{#378686}

Patch Set 1 #

Patch Set 2 : rebase (conflict in content/test/test_blink_web_unit_test_support.cc) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -31 lines) Patch
M content/test/test_blink_web_unit_test_support.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.md View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAudioElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSourceElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTagNames.in View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/MediaError.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/TimeRanges.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749683002/1
4 years, 9 months ago (2016-02-29 10:41:30 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 12:07:11 UTC) #4
philipj_slow
PTAL. Is there an umbrella bug for cleaning up RuntimeEnabledFeatures that I should use?
4 years, 9 months ago (2016-02-29 13:05:03 UTC) #8
mlamouri (slow - plz ping)
drive-by lgtm
4 years, 9 months ago (2016-03-01 03:26:21 UTC) #10
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-01 14:42:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749683002/1
4 years, 9 months ago (2016-03-01 17:14:20 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/166372) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-01 17:19:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749683002/20001
4 years, 9 months ago (2016-03-02 02:48:19 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 04:22:17 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 04:23:47 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b90a631cdd8bf933a4e935db73605796e4c5461c
Cr-Commit-Position: refs/heads/master@{#378686}

Powered by Google App Engine
This is Rietveld 408576698