Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1742883002: ozone/platform/wayland: Drop WaylandWindow::GetWidget() (Closed)

Created:
4 years, 10 months ago by Michael Forney
Modified:
4 years, 9 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wayland-test1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone/platform/wayland: Drop WaylandWindow::GetWidget() It was only used in tests and WaylandDisplay::{Add,Remove}Window, and WaylandWindow can just provide the widget as an argument. This way we can drop WaylandWindowInitializeTest, and just use the widget from OnAcceleratedWidgetAvailable in all tests. This more closely matches reality. Also, inline and rename GetSurface() -> surface() because it is a simple accessor. BUG=578890 Committed: https://crrev.com/dbdd487f447892b2b3b06e366e72553c21bdb2cb Cr-Commit-Position: refs/heads/master@{#378733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M ui/ozone/platform/wayland/wayland_display.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_display.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/wayland/wayland_surface_factory_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_test.cc View 2 chunks +7 lines, -1 line 0 comments Download
M ui/ozone/platform/wayland/wayland_window.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_window.cc View 2 chunks +2 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Michael Forney
4 years, 10 months ago (2016-02-27 00:02:29 UTC) #2
spang
lgtm
4 years, 9 months ago (2016-03-01 21:41:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742883002/1
4 years, 9 months ago (2016-03-02 12:09:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 12:56:06 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 12:57:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbdd487f447892b2b3b06e366e72553c21bdb2cb
Cr-Commit-Position: refs/heads/master@{#378733}

Powered by Google App Engine
This is Rietveld 408576698