Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1740303002: ozone/platform/wayland: Add WaylandTest base class to eliminate redundancy (Closed)

Created:
4 years, 10 months ago by Michael Forney
Modified:
4 years, 9 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone/platform/wayland: Add WaylandTest base class to eliminate redundancy Rather than have WaylandWindowTest, WaylandSurfaceFactoryTest, and soon WaylandPointerTest all do the same setup, synchronization, and tear-down, just use a common base class. BUG=578890 Committed: https://crrev.com/8ad5dc33e673b7f67ba1a02a03268980f87c56a7 Cr-Commit-Position: refs/heads/master@{#378724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -95 lines) Patch
M ui/ozone/platform/wayland/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/wayland/mock_platform_window_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/ozone/platform/wayland/wayland.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_surface_factory_unittest.cc View 2 chunks +5 lines, -41 lines 0 comments Download
A ui/ozone/platform/wayland/wayland_test.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ui/ozone/platform/wayland/wayland_test.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_window_unittest.cc View 2 chunks +4 lines, -54 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Michael Forney
4 years, 10 months ago (2016-02-27 00:02:11 UTC) #3
spang
lgtm
4 years, 9 months ago (2016-03-01 21:45:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740303002/1
4 years, 9 months ago (2016-03-02 10:05:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 10:50:23 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 10:51:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ad5dc33e673b7f67ba1a02a03268980f87c56a7
Cr-Commit-Position: refs/heads/master@{#378724}

Powered by Google App Engine
This is Rietveld 408576698