content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java - Issue 1742763002: Don't create a new entry in the Nav stack when reloading a page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java

Issue 1742763002: Don't create a new entry in the Nav stack when reloading a page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add back missing part of change Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java

diff --git a/content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java b/content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java

index 7194f8edb21d445b79fa15ceaa46224d39968faf..89167b88ff3231d5fa0d4b00e6e207ea6fc2e85f 100644

--- a/content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java

+++ b/content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java

@@ -426,10 +426,6 @@ public class LoadUrlParams {

/**

* @param shouldReplaceCurrentEntry Whether this navigation should replace

* the current navigation entry.

- *

- * Don't use this. This is a temporary hack that will be removed.

- * TODO(lizeb): Remove this and {@link getShouldReplaceCurrentEntry} once

- * crbug.com/521729 is fixed.

public void setShouldReplaceCurrentEntry(boolean shouldReplaceCurrentEntry) {

mShouldReplaceCurrentEntry = shouldReplaceCurrentEntry;

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java ('k') | no next file » | no next file with comments »