Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5122)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Issue 1742763002: Don't create a new entry in the Nav stack when reloading a page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add back missing part of change Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
index 16a55f288546eb9e43d48fe760250a85418156f8..24b6befe6c0adeace0c1ca5c8a2c80ca67f84997 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
@@ -131,7 +131,10 @@ public class OfflinePageUtils {
// If we are reloading an offline page, but are online, get the online version.
if (newUrl.equals(tab.getUrl()) && isConnected()) {
Log.i(TAG, "Refreshing to the online version of an offline page, since we are online");
- tab.loadUrl(new LoadUrlParams(tab.getOfflinePageOriginalUrl(), PageTransition.RELOAD));
+ LoadUrlParams params =
+ new LoadUrlParams(tab.getOfflinePageOriginalUrl(), PageTransition.RELOAD);
+ params.setShouldReplaceCurrentEntry(true);
+ tab.loadUrl(params);
}
}
@@ -219,8 +222,11 @@ public class OfflinePageUtils {
RecordUserAction.record("OfflinePages.ReloadButtonClicked");
Tab foundTab = activity.getTabModelSelector().getTabById(tabId);
if (foundTab == null) return;
- foundTab.loadUrl(new LoadUrlParams(
- foundTab.getOfflinePageOriginalUrl(), PageTransition.RELOAD));
+
+ LoadUrlParams params = new LoadUrlParams(
+ foundTab.getOfflinePageOriginalUrl(), PageTransition.RELOAD);
+ params.setShouldReplaceCurrentEntry(true);
+ foundTab.loadUrl(params);
}
@Override
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698