Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  ->
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, the depencency breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch is closed.

BUG=492204, 590268
Committed: https://crrev.com/0f6c2ac3d767f8bd859db4cc0bdddaf08a2ffd59
Cr-Commit-Position: refs/heads/master@{#381004}

[juncai, 2016-02-26 18:42:07]

Description was changed from

==========
renamed web_usb_permission_bubble to web_usb_permission_request

BUG=
==========

to

==========
This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_permission_request.cc/h
webusb_permission_bubble.mojom  ->  web_usb_permission_request.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

This patch is a smaller patch for:
https://codereview.chromium.org/1624573004/
Since the above patch was delayed due to some code refactoring. 

BUG=492204, 590268
==========

[juncai, 2016-02-26 18:46:34]

juncai@chromium.org changed reviewers:
+ jam@chromium.org, reillyg@chromium.org

[juncai, 2016-02-26 18:46:35]

jam@chromium.org: Please review changes in 
//chrome/browser/chrome_content_browser_client.cc
//chrome/chrome_browser.gypi

reillyg@chromium.org: Please review changes in 
the remaining files

[juncai, 2016-02-26 18:47:26]

Description was changed from

==========
This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_permission_request.cc/h
webusb_permission_bubble.mojom  ->  web_usb_permission_request.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

This patch is a smaller patch for:
https://codereview.chromium.org/1624573004/
Since the above patch was delayed due to some code refactoring. 

BUG=492204, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_permission_request.cc/h
webusb_permission_bubble.mojom  ->  web_usb_permission_request.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

This patch is a smaller patch for:
https://codereview.chromium.org/1624573004/
Since the above patch was delayed due to some code refactoring. 

BUG=492204, 590268
==========

[Reilly Grant (use Gerrit), 2016-02-26 19:09:54]

I'd actually suggest something like UsbChooserService since this interface
doesn't really represent a bubble but simply a service that allows the renderer
to request permission to access a device. It's not even particularly specific to
WebUSB.

[jam, 2016-02-26 21:40:41]

Thanks for following up on this. I commented on
https://codereview.chromium.org/1624573004/, i think it's better to land that
now. the gypi files are non ideal, but that's ok because gyp is going away and
the gn files are fine. thanks

[juncai, 2016-02-27 00:06:40]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_permission_request.cc/h
webusb_permission_bubble.mojom  ->  web_usb_permission_request.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

This patch is a smaller patch for:
https://codereview.chromium.org/1624573004/
Since the above patch was delayed due to some code refactoring. 

BUG=492204, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_permission_request.cc/h
webusb_permission_bubble.mojom  ->  web_usb_permission_request.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

This patch is a smaller patch for:
https://codereview.chromium.org/1624573004/
Since the above patch was delayed due to some code refactoring. 

BUG=492204, 580700, 590268
==========

[juncai, 2016-02-27 00:07:12]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_permission_request.cc/h
webusb_permission_bubble.mojom  ->  web_usb_permission_request.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

This patch is a smaller patch for:
https://codereview.chromium.org/1624573004/
Since the above patch was delayed due to some code refactoring. 

BUG=492204, 580700, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_permission_request.cc/h
webusb_permission_bubble.mojom  ->  web_usb_permission_request.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

This patch is a smaller patch for:
https://codereview.chromium.org/1624573004/
Since the above patch was delayed due to some code refactoring. 

BUG=492204, 590268
==========

[juncai, 2016-02-27 00:11:52]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_permission_request.cc/h
webusb_permission_bubble.mojom  ->  web_usb_permission_request.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

This patch is a smaller patch for:
https://codereview.chromium.org/1624573004/
Since the above patch was delayed due to some code refactoring. 

BUG=492204, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch will be closed.

BUG=492204, 590268
==========

[juncai, 2016-02-27 00:15:57]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch will be closed.

BUG=492204, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom
it removes the //components dependency of:
//content/renderer/usb/DEPS, which breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch will be closed.

BUG=492204, 590268
==========

[juncai, 2016-02-27 00:16:50]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom
it removes the //components dependency of:
//content/renderer/usb/DEPS, which breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch will be closed.

BUG=492204, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom
it removes the //components dependency of:
//content/renderer/usb/DEPS, which breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch will be closed.

BUG=492204, 590268
==========

[juncai, 2016-02-27 00:17:40]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom
it removes the //components dependency of:
//content/renderer/usb/DEPS, which breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch will be closed.

BUG=492204, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, which breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch will be closed.

BUG=492204, 590268
==========

[juncai, 2016-02-27 00:26:50]

I updated this patch. Please review.

[juncai, 2016-02-27 00:32:07]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, which breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch will be closed.

BUG=492204, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, which breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch is closed.

BUG=492204, 590268
==========

[juncai, 2016-02-27 00:37:55]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, which breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch is closed.

BUG=492204, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, the depencency breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch is closed.

BUG=492204, 590268
==========

[Reilly Grant (use Gerrit), 2016-02-27 02:22:56]

https://codereview.chromium.org/1742753002/diff/40001/components/webusb/publi...
File components/webusb/public/interfaces/BUILD.gn (left):

https://codereview.chromium.org/1742753002/diff/40001/components/webusb/publi...
components/webusb/public/interfaces/BUILD.gn:1: # Copyright 2015 The Chromium
Authors. All rights reserved.
It looks like this file becomes empty instead of being deleted? Is this true or
a bug in Rietveld?

https://codereview.chromium.org/1742753002/diff/40001/content/app/BUILD.gn
File content/app/BUILD.gn (right):

https://codereview.chromium.org/1742753002/diff/40001/content/app/BUILD.gn#ne...
content/app/BUILD.gn:60: "//device/usb",
This seems like an awfully high level place to add a dependency.
//content/renderer/usb already depends on //device/usb. What changed to
necessitate this?

https://codereview.chromium.org/1742753002/diff/40001/content/content_app.gypi
File content/content_app.gypi (right):

https://codereview.chromium.org/1742753002/diff/40001/content/content_app.gyp...
content/content_app.gypi:51: '../device/usb/usb.gyp:device_usb',
Ditto.

https://codereview.chromium.org/1742753002/diff/40001/device/usb/public/inter...
File device/usb/public/interfaces/chooser_service.mojom (right):

https://codereview.chromium.org/1742753002/diff/40001/device/usb/public/inter...
device/usb/public/interfaces/chooser_service.mojom:5: module device;
module device.usb;

[juncai, 2016-02-29 18:55:23]

https://codereview.chromium.org/1742753002/diff/40001/components/webusb/publi...
File components/webusb/public/interfaces/BUILD.gn (left):

https://codereview.chromium.org/1742753002/diff/40001/components/webusb/publi...
components/webusb/public/interfaces/BUILD.gn:1: # Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/02/27 02:22:56, Reilly Grant wrote:
> It looks like this file becomes empty instead of being deleted? Is this true
or
> a bug in Rietveld?

It was deleted. The folder //components/webusb/public doesn't exist in my local
machine.

https://codereview.chromium.org/1742753002/diff/40001/content/app/BUILD.gn
File content/app/BUILD.gn (right):

https://codereview.chromium.org/1742753002/diff/40001/content/app/BUILD.gn#ne...
content/app/BUILD.gn:60: "//device/usb",
On 2016/02/27 02:22:56, Reilly Grant wrote:
> This seems like an awfully high level place to add a dependency.
> //content/renderer/usb already depends on //device/usb. What changed to
> necessitate this?

ok, I moved this dep to the above:
else if (is_android)
since it is needed by Android.

In my machine, the Android build failed without this dep:
../../content/app/android/library_loader_hooks.cc:80: error: undefined reference
to 'device::android::RegisterUsbJni(_JNIEnv*)'

https://codereview.chromium.org/1742753002/diff/40001/content/content_app.gypi
File content/content_app.gypi (right):

https://codereview.chromium.org/1742753002/diff/40001/content/content_app.gyp...
content/content_app.gypi:51: '../device/usb/usb.gyp:device_usb',
On 2016/02/27 02:22:56, Reilly Grant wrote:
> Ditto.

explained in the comment at:
//device/usb/public/interfaces/BUILD.gn

https://codereview.chromium.org/1742753002/diff/40001/device/usb/public/inter...
File device/usb/public/interfaces/chooser_service.mojom (right):

https://codereview.chromium.org/1742753002/diff/40001/device/usb/public/inter...
device/usb/public/interfaces/chooser_service.mojom:5: module device;
On 2016/02/27 02:22:56, Reilly Grant wrote:
> module device.usb;

Done.

[Reilly Grant (use Gerrit), 2016-02-29 18:59:13]

lgtm

[juncai, 2016-03-01 19:27:27]

kindly ping jam@, :).

[jam, 2016-03-14 16:08:23]

lgtm, sorry for the delay I didn't see this and then was away.

[juncai, 2016-03-14 16:50:03]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-03-14 16:50:04]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/1742753002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-14 16:50:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1742753002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1742753002/120001

[commit-bot: I haz the power, 2016-03-14 18:04:39]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, the depencency breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch is closed.

BUG=492204, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, the depencency breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch is closed.

BUG=492204, 590268
==========

[commit-bot: I haz the power, 2016-03-14 18:04:41]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-14 18:05:59]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  -> 
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the 
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, the depencency breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch is closed.

BUG=492204, 590268
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  ->
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, the depencency breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch is closed.

BUG=492204, 590268

Committed: https://crrev.com/0f6c2ac3d767f8bd859db4cc0bdddaf08a2ffd59
Cr-Commit-Position: refs/heads/master@{#381004}
==========

[commit-bot: I haz the power, 2016-03-14 18:06:00]

Patchset 7 (id:??) landed as
https://crrev.com/0f6c2ac3d767f8bd859db4cc0bdddaf08a2ffd59
Cr-Commit-Position: refs/heads/master@{#381004}

[dewittj, 2016-03-14 19:04:35]

On 2016/03/14 18:06:00, commit-bot: I haz the power wrote:
> Patchset 7 (id:??) landed as
> https://crrev.com/0f6c2ac3d767f8bd859db4cc0bdddaf08a2ffd59
> Cr-Commit-Position: refs/heads/master@{#381004}

I believe this bot breaks a test.  See, e.g.:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6...

I will revert this patch in the next few minutes unless I hear from you.

[dewittj, 2016-03-14 19:05:36]

Description was changed from

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  ->
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, the depencency breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch is closed.

BUG=492204, 590268

Committed: https://crrev.com/0f6c2ac3d767f8bd859db4cc0bdddaf08a2ffd59
Cr-Commit-Position: refs/heads/master@{#381004}
==========

to

==========
Rename web_usb_permission_bubble.cc/h and webusb_permission_bubble.mojom

This patch renamed the following three files:
web_usb_permission_bubble.cc/h  ->  web_usb_chooser_service.cc/h
//components/webusb/public/interfaces/webusb_permission_bubble.mojom  ->
//device/usb/public/interfaces/chooser_service.mojom

The previous filenames are misleading and confusing,
since the word "bubble" in the original filename
is a Chrome UI concept, but these files are not UI
related. The new filenames better reflect the
responsibilities and roles of these files.

By moving
//components/webusb/public/interfaces/webusb_permission_bubble.mojom to
//device/usb/public/interfaces/chooser_service.mojom,
it removes the //components dependency of:
//content/renderer/usb/DEPS, the depencency breaks the DEP rule at:
//content/renderer/DEPS

This patch is a follow-up patch for:
https://codereview.chromium.org/1624573004/
The above patch is closed.

BUG=492204, 590268

Committed: https://crrev.com/0f6c2ac3d767f8bd859db4cc0bdddaf08a2ffd59
Cr-Commit-Position: refs/heads/master@{#381004}
==========

[Reilly Grant (use Gerrit), 2016-03-14 19:21:01]

On 2016/03/14 at 19:04:35, dewittj wrote:
> On 2016/03/14 18:06:00, commit-bot: I haz the power wrote:
> > Patchset 7 (id:??) landed as
> > https://crrev.com/0f6c2ac3d767f8bd859db4cc0bdddaf08a2ffd59
> > Cr-Commit-Position: refs/heads/master@{#381004}
> 
> I believe this bot breaks a test.  See, e.g.:
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6...
> 
> I will revert this patch in the next few minutes unless I hear from you.

Yes, sorry Jun for not warning you about this footgun.
third_party/Webkit/LayoutTests/usb/resources/usb-helpers.js contains references
to the mojom paths and needs to be updated to match the new names.