Rename webusb_permission_bubble.mojom and move it to //content/public

Rename webusb_permission_bubble.mojom and move it to //content/public

In patch:
https://codereview.chromium.org/1404213004/

//content/renderer/usb/DEPS
has //components dependency, which breaks the DEP rule at:
//content/renderer/DEPS

Need to change the name of webusb_permission_bubble.mojom to be
web_usb_permission_request.mojom and move it to //content/public.

BUG=580700

[nodir, 2016-01-23 01:45:59]

The CQ bit was checked by nodir@chromium.org to run a CQ dry run

[nodir, 2016-01-23 01:46:29]

There was a problem with the tryjobs. I've rescheduled them.

[commit-bot: I haz the power, 2016-01-23 01:47:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1624573004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1624573004/20001

[commit-bot: I haz the power, 2016-01-23 01:55:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-23 01:55:39]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[juncai, 2016-01-27 21:46:34]

juncai@chromium.org changed reviewers:
+ jam@chromium.org
- nodir@chromium.org

[juncai, 2016-01-27 21:46:34]

Please review this patch.

[juncai, 2016-01-27 21:52:58]

juncai@chromium.org changed reviewers:
+ palmer@chromium.org, reillyg@chromium.org

[juncai, 2016-01-27 21:52:59]

palmer@chromium.org: Please review changes in 
//content/public/common/web_usb_permission_request.mojom

reillyg@chromium.org: Please review changes in 
//chrome/browser/usb/
//components/webusb/
//content/renderer/usb/

jam@chromium.org: Please review changes in the remaining files.

[juncai, 2016-01-27 21:54:10]

Description was changed from

==========
rename webusb_permission_bubble.mojom and move it to //content/public

In patch:
https://codereview.chromium.org/1404213004/

//content/renderer/usb/DEPS
has //components dependency, which breaks the DEP rule at:
//content/renderer/DEPS

Need to change the name of webusb_permission_bubble.mojom to be
web_usb_permission_request.mojom and move it to //content/public.

BUG=580700
==========

to

==========
rename webusb_permission_bubble.mojom and move it to //content/public

In patch:
https://codereview.chromium.org/1404213004/

//content/renderer/usb/DEPS
has //components dependency, which breaks the DEP rule at:
//content/renderer/DEPS

Need to change the name of webusb_permission_bubble.mojom to be
web_usb_permission_request.mojom and move it to //content/public.

BUG=580700
==========

[Reilly Grant (use Gerrit), 2016-01-27 22:00:16]

lgtm

[jam, 2016-01-27 23:36:51]

https://codereview.chromium.org/1624573004/diff/280001/chrome/chrome_browser....
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1624573004/diff/280001/chrome/chrome_browser....
chrome/chrome_browser.gypi:3317:
'../content/content_common_mojo_bindings.gyp:content_common_mojo_bindings',
chrome/browser shouldn't depend on it. it should get it through its dependency
on content_common target

so please make content_common have a dependency on the new mojo target

https://codereview.chromium.org/1624573004/diff/280001/content/renderer/usb/DEPS
File content/renderer/usb/DEPS (right):

https://codereview.chromium.org/1624573004/diff/280001/content/renderer/usb/D...
content/renderer/usb/DEPS:2: "+content/public/common",
not needed (content/DEPS already has it)

https://codereview.chromium.org/1624573004/diff/280001/content/renderer/usb/w...
File content/renderer/usb/web_usb_client_impl.h (right):

https://codereview.chromium.org/1624573004/diff/280001/content/renderer/usb/w...
content/renderer/usb/web_usb_client_impl.h:36:
content::WebUsbPermissionRequestPtr web_usb_permission_request_;
no content::

[juncai, 2016-01-28 21:08:32]

https://codereview.chromium.org/1624573004/diff/280001/chrome/chrome_browser....
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1624573004/diff/280001/chrome/chrome_browser....
chrome/chrome_browser.gypi:3317:
'../content/content_common_mojo_bindings.gyp:content_common_mojo_bindings',
On 2016/01/27 23:36:51, jam wrote:
> chrome/browser shouldn't depend on it. it should get it through its dependency
> on content_common target
> 
> so please make content_common have a dependency on the new mojo target

https://code.google.com/p/chromium/codesearch#chromium/src/content/content_co...
The content_common already has dep on the content_common_mojo_bindings

The difference between patch set 20 and 21 is the
'../content/content_common_mojo_bindings.gyp:content_common_mojo_bindings',
to the chrome_browser.gypi, without that, many trybots have compile errors at
patch set 20.

https://codereview.chromium.org/1624573004/diff/280001/content/renderer/usb/DEPS
File content/renderer/usb/DEPS (right):

https://codereview.chromium.org/1624573004/diff/280001/content/renderer/usb/D...
content/renderer/usb/DEPS:2: "+content/public/common",
On 2016/01/27 23:36:51, jam wrote:
> not needed (content/DEPS already has it)

Done.

https://codereview.chromium.org/1624573004/diff/280001/content/renderer/usb/w...
File content/renderer/usb/web_usb_client_impl.h (right):

https://codereview.chromium.org/1624573004/diff/280001/content/renderer/usb/w...
content/renderer/usb/web_usb_client_impl.h:36:
content::WebUsbPermissionRequestPtr web_usb_permission_request_;
On 2016/01/27 23:36:51, jam wrote:
> no content::

Done.

[jam, 2016-01-29 17:58:53]

https://codereview.chromium.org/1624573004/diff/400001/content/content_common...
File content/content_common_mojo_bindings.gyp (right):

https://codereview.chromium.org/1624573004/diff/400001/content/content_common...
content/content_common_mojo_bindings.gyp:65: 'target_name':
'content_web_usb_permission_request_mojo_bindings_mojom',
why are you adding new targets instead of using the ones above?

is this to workaround the circular dependency issue where device depends on
components? if so, that should be fixed first and then we wouldn't need new
targets here.

[juncai, 2016-01-29 18:02:53]

On 2016/01/29 17:58:53, jam wrote:
>
https://codereview.chromium.org/1624573004/diff/400001/content/content_common...
> File content/content_common_mojo_bindings.gyp (right):
> 
>
https://codereview.chromium.org/1624573004/diff/400001/content/content_common...
> content/content_common_mojo_bindings.gyp:65: 'target_name':
> 'content_web_usb_permission_request_mojo_bindings_mojom',
> why are you adding new targets instead of using the ones above?
> 
> is this to workaround the circular dependency issue where device depends on
> components? if so, that should be fixed first and then we wouldn't need new
> targets here.

ah, yes, patch 21 was done yesterday before we talked about the circular
dependency in the office, :), just some experiments. I am working on a new patch
that removes the circular dependency. After the new patch lands, I will try a
new patch set for this patch. Sorry for the confusion.

[palmer, 2016-01-29 23:38:53]

lgtm

[juncai, 2016-02-03 19:00:41]

Description was changed from

==========
rename webusb_permission_bubble.mojom and move it to //content/public

In patch:
https://codereview.chromium.org/1404213004/

//content/renderer/usb/DEPS
has //components dependency, which breaks the DEP rule at:
//content/renderer/DEPS

Need to change the name of webusb_permission_bubble.mojom to be
web_usb_permission_request.mojom and move it to //content/public.

BUG=580700
==========

to

==========
Rename webusb_permission_bubble.mojom and move it to //content/public

In patch:
https://codereview.chromium.org/1404213004/

//content/renderer/usb/DEPS
has //components dependency, which breaks the DEP rule at:
//content/renderer/DEPS

Need to change the name of webusb_permission_bubble.mojom to be
web_usb_permission_request.mojom and move it to //content/public.

BUG=580700
==========

[jam, 2016-02-26 21:40:11]

lgtm

https://codereview.chromium.org/1624573004/diff/400001/content/content_common...
File content/content_common_mojo_bindings.gyp (right):

https://codereview.chromium.org/1624573004/diff/400001/content/content_common...
content/content_common_mojo_bindings.gyp:65: 'target_name':
'content_web_usb_permission_request_mojo_bindings_mojom',
On 2016/01/29 17:58:53, jam wrote:
> why are you adding new targets instead of using the ones above?
> 
> is this to workaround the circular dependency issue where device depends on
> components? if so, that should be fixed first and then we wouldn't need new
> targets here. 

just add a comment that says you're adding this only because of the
device->component dependency in gyp