Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1742603004: Use Scoped version of AddTraceEvent for V8 Tracing in Chrome (Closed)

Created:
4 years, 10 months ago by fmeawad
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Scoped version of AddTraceEvent for V8 Tracing in Chrome We added support for the scope in AddTraceEvent (tracked by https://bugs.chromium.org/p/v8/issues/detail?id=4565) (Wait until a v8 DEPS roll before commiting this CL) BUG=446513 Committed: https://crrev.com/ab615cf0028001ef0fae5cf52ecb0307ab677451 Cr-Commit-Position: refs/heads/master@{#378473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M gin/public/v8_platform.h View 1 chunk +1 line, -0 lines 0 comments Download
M gin/v8_platform.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fmeawad
PTAL
4 years, 10 months ago (2016-02-26 22:51:00 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-01 14:23:32 UTC) #3
chiniforooshan
On 2016/03/01 14:23:32, jochen wrote: > lgtm
4 years, 9 months ago (2016-03-01 15:20:44 UTC) #4
chiniforooshan
On 2016/02/26 22:51:00, fmeawad wrote: > PTAL LGTM
4 years, 9 months ago (2016-03-01 15:20:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742603004/1
4 years, 9 months ago (2016-03-01 16:30:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 18:03:39 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 18:04:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab615cf0028001ef0fae5cf52ecb0307ab677451
Cr-Commit-Position: refs/heads/master@{#378473}

Powered by Google App Engine
This is Rietveld 408576698