Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3023)

Unified Diff: gin/v8_platform.cc

Issue 1742603004: Use Scoped version of AddTraceEvent for V8 Tracing in Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/public/v8_platform.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/v8_platform.cc
diff --git a/gin/v8_platform.cc b/gin/v8_platform.cc
index 26537bf8f4461423ded5f4b6003220b87b92d722..be7f5c2185d73498980cc1d142a78405ee4075d4 100644
--- a/gin/v8_platform.cc
+++ b/gin/v8_platform.cc
@@ -75,6 +75,7 @@ const char* V8Platform::GetCategoryGroupName(
uint64_t V8Platform::AddTraceEvent(char phase,
const uint8_t* category_enabled_flag,
const char* name,
+ const char* scope,
uint64_t id,
uint64_t bind_id,
int32_t num_args,
@@ -84,9 +85,9 @@ uint64_t V8Platform::AddTraceEvent(char phase,
unsigned int flags) {
base::trace_event::TraceEventHandle handle =
TRACE_EVENT_API_ADD_TRACE_EVENT_WITH_BIND_ID(
- phase, category_enabled_flag, name,
- trace_event_internal::kGlobalScope, id, bind_id, num_args, arg_names,
- arg_types, (const long long unsigned int*)arg_values, NULL, flags);
+ phase, category_enabled_flag, name, scope, id, bind_id, num_args,
+ arg_names, arg_types, (const long long unsigned int*)arg_values, NULL,
+ flags);
uint64_t result;
memcpy(&result, &handle, sizeof(result));
return result;
« no previous file with comments | « gin/public/v8_platform.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698