Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1742353002: Make HTMLSelectElementTest.DefaultToolTip work non-Oilpan (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make HTMLSelectElementTest.DefaultToolTip work non-Oilpan R=tkent BUG= Committed: https://crrev.com/2f9d15b0e97049453289a0c9788f77011c4e015e Cr-Commit-Position: refs/heads/master@{#378324}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742353002/1
4 years, 9 months ago (2016-02-29 16:44:02 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 17:39:08 UTC) #4
sof
please take a look.
4 years, 9 months ago (2016-02-29 18:27:24 UTC) #5
tkent
lgtm. Thank you for fixing this. https://codereview.chromium.org/1742353002/diff/1/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp File third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp (right): https://codereview.chromium.org/1742353002/diff/1/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp#newcode337 third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp:337: option->remove(); I see. ...
4 years, 9 months ago (2016-02-29 23:21:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742353002/1
4 years, 9 months ago (2016-02-29 23:22:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 23:59:01 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 00:00:55 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2f9d15b0e97049453289a0c9788f77011c4e015e
Cr-Commit-Position: refs/heads/master@{#378324}

Powered by Google App Engine
This is Rietveld 408576698