Make HTMLSelectElementTest.DefaultToolTip work non-Oilpan

third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/html/HTMLSelectElement.h"
 
 #include "core/frame/FrameView.h"
 #include "core/html/HTMLDocument.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/forms/FormController.h"
@@ skipping 292 matching lines @@
     EXPECT_EQ(-1, select->activeSelectionEndListIndex());
     select->appendChild(option, ASSERT_NO_EXCEPTION);
     EXPECT_EQ(1, select->activeSelectionEndListIndex());
 }
 
 TEST_F(HTMLSelectElementTest, DefaultToolTip)
 {
     document().documentElement()->setInnerHTML("<select size=4><option value="">Placeholder</option><optgroup><option>o2</option></optgroup></select>", ASSERT_NO_EXCEPTION);
     document().view()->updateAllLifecyclePhases();
     HTMLSelectElement* select = toHTMLSelectElement(document().body()->firstChild());
-    Element* option = toElement(select->firstChild());
-    Element* optgroup = toElement(option->nextSibling());
+    RefPtrWillBeRawPtr<Element> option = toElement(select->firstChild());
+    RefPtrWillBeRawPtr<Element> optgroup = toElement(option->nextSibling());
 
     EXPECT_EQ(String(), select->defaultToolTip()) << "defaultToolTip for SELECT without FORM and without required attribute should return null string.";
     EXPECT_EQ(select->defaultToolTip(), option->defaultToolTip());
     EXPECT_EQ(select->defaultToolTip(), optgroup->defaultToolTip());
 
     select->setBooleanAttribute(HTMLNames::requiredAttr, true);
     EXPECT_EQ("<<ValidationValueMissingForSelect>>", select->defaultToolTip()) << "defaultToolTip for SELECT without FORM and with required attribute should return a valueMissing message.";
     EXPECT_EQ(select->defaultToolTip(), option->defaultToolTip());
     EXPECT_EQ(select->defaultToolTip(), optgroup->defaultToolTip());
 
     RefPtrWillBeRawPtr<HTMLFormElement> form = HTMLFormElement::create(document());
     document().body()->appendChild(form.get());
     form->appendChild(select);
     EXPECT_EQ("<<ValidationValueMissingForSelect>>", select->defaultToolTip()) << "defaultToolTip for SELECT with FORM and required attribute should return a valueMissing message.";
     EXPECT_EQ(select->defaultToolTip(), option->defaultToolTip());
     EXPECT_EQ(select->defaultToolTip(), optgroup->defaultToolTip());
 
     form->setBooleanAttribute(HTMLNames::novalidateAttr, true);
     EXPECT_EQ(String(), select->defaultToolTip()) << "defaultToolTip for SELECT with FORM[novalidate] and required attribute should return null string.";
     EXPECT_EQ(select->defaultToolTip(), option->defaultToolTip());
     EXPECT_EQ(select->defaultToolTip(), optgroup->defaultToolTip());
 
     option->remove();

[tkent, 2016/02/29 23:21:24]

I see.  This clears the reference count.

     optgroup->remove();
     EXPECT_EQ(String(), option->defaultToolTip());
     EXPECT_EQ(String(), optgroup->defaultToolTip());
 }
 
 } // namespace blink