Cast:Transport: Dividing A/V Initialization pipeline

media/cast/transport/cast_transport_config.h

Index: media/cast/transport/cast_transport_config.h
diff --git a/media/cast/transport/cast_transport_config.h b/media/cast/transport/cast_transport_config.h
index 90d039cb34fc9203ec71a93378d3d9bf28078e8d..9191606260d188fe851a4dd1493e08593e64de3c 100644
--- a/media/cast/transport/cast_transport_config.h
+++ b/media/cast/transport/cast_transport_config.h
@@ -43,29 +43,33 @@ struct RtpConfig {
   int payload_type;
 };
 
-struct CastTransportConfig {
-  CastTransportConfig();
-  ~CastTransportConfig();
+// TODO(mikhal): Consider combining this with the cast_sender config.
+struct CastTransportBaseConfig {
+  CastTransportBaseConfig();
+  ~CastTransportBaseConfig();
 
-  // Transport: Local receiver.
-  net::IPEndPoint receiver_endpoint;
-  net::IPEndPoint local_endpoint;
-
-  uint32 audio_ssrc;
-  uint32 video_ssrc;
+  uint32 ssrc;

[Ami GONE FROM CHROMIUM, 2014/02/25 18:35:08]

I don't understand this sentence.  Are you saying that most callers want the
same (default/zero) values?  If anything that's a reason to have an explicit
CreateDefaultConfig() factory method, not a reason to make state mutable.
Ironically, it makes testing less relevant as well, b/c it makes it less likely
that you have good test coverage.

[mikhal1, 2014/02/25 22:33:33]

True. Will update that in a separate cl, as this has nothing to do with this cl.
On 2014/02/25 18:35:08, Ami Fischman wrote:

+  RtpConfig rtp_config;
+  std::string aes_key;      // Binary string of size kAesKeySize.
+  std::string aes_iv_mask;  // Binary string of size kAesBlockSize.
+};
 
-  VideoCodec video_codec;
-  AudioCodec audio_codec;
+struct CastTransportAudioConfig {
+  CastTransportAudioConfig();
+  ~CastTransportAudioConfig();
 
-  // RTP.
-  RtpConfig audio_rtp_config;
-  RtpConfig video_rtp_config;
+  CastTransportBaseConfig base;
+  AudioCodec codec;
+  int frequency;
+  int channels;
+};
 
-  int audio_frequency;
-  int audio_channels;
+struct CastTransportVideoConfig {
+  CastTransportVideoConfig();
+  ~CastTransportVideoConfig();
 
-  std::string aes_key;      // Binary string of size kAesKeySize.
-  std::string aes_iv_mask;  // Binary string of size kAesBlockSize.
+  CastTransportBaseConfig base;
+  VideoCodec codec;
 };
 
 struct EncodedVideoFrame {