Cast:Transport: Dividing A/V Initialization pipeline

media/cast/transport/cast_transport_config.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_CONFIG_H_
 #define MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_CONFIG_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 25 matching lines @@
   kAudioCodecLast = kExternalAudio
 };
 
 struct RtpConfig {
   RtpConfig();
   int history_ms;  // The time RTP packets are stored for retransmissions.
   int max_delay_ms;
   int payload_type;
 };
 
-struct CastTransportConfig {
-  CastTransportConfig();
-  ~CastTransportConfig();
+// TODO(mikhal): Consider combining this with the cast_sender config.
+struct CastTransportBaseConfig {
+  CastTransportBaseConfig();
+  ~CastTransportBaseConfig();
 
-  // Transport: Local receiver.
-  net::IPEndPoint receiver_endpoint;
-  net::IPEndPoint local_endpoint;
-
-  uint32 audio_ssrc;
-  uint32 video_ssrc;
-
-  VideoCodec video_codec;
-  AudioCodec audio_codec;
-
-  // RTP.
-  RtpConfig audio_rtp_config;
-  RtpConfig video_rtp_config;
-
-  int audio_frequency;
-  int audio_channels;
-
+  uint32 ssrc;

[Ami GONE FROM CHROMIUM, 2014/02/25 18:35:08]

I don't understand this sentence.  Are you saying that most callers want the
same (default/zero) values?  If anything that's a reason to have an explicit
CreateDefaultConfig() factory method, not a reason to make state mutable.
Ironically, it makes testing less relevant as well, b/c it makes it less likely
that you have good test coverage.

[mikhal1, 2014/02/25 22:33:33]

True. Will update that in a separate cl, as this has nothing to do with this cl.
On 2014/02/25 18:35:08, Ami Fischman wrote:

+  RtpConfig rtp_config;
   std::string aes_key;      // Binary string of size kAesKeySize.
   std::string aes_iv_mask;  // Binary string of size kAesBlockSize.
 };
 
+struct CastTransportAudioConfig {
+  CastTransportAudioConfig();
+  ~CastTransportAudioConfig();
+
+  CastTransportBaseConfig base;
+  AudioCodec codec;
+  int frequency;
+  int channels;
+};
+
+struct CastTransportVideoConfig {
+  CastTransportVideoConfig();
+  ~CastTransportVideoConfig();
+
+  CastTransportBaseConfig base;
+  VideoCodec codec;
+};
+
 struct EncodedVideoFrame {
   EncodedVideoFrame();
   ~EncodedVideoFrame();
 
   VideoCodec codec;
   bool key_frame;
   uint32 frame_id;
   uint32 last_referenced_frame_id;
   uint32 rtp_timestamp;
   std::string data;
@@ skipping 92 matching lines @@
          lhs.rtp_timestamp == rhs.rtp_timestamp &&
          lhs.send_packet_count == rhs.send_packet_count &&
          lhs.send_octet_count == rhs.send_octet_count;
 }
 
 }  // namespace transport
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_CONFIG_H_