Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1950)

Unified Diff: chrome/browser/origin_trials/origin_trial_controller_unittest.cc

Issue 1741783002: Add disabled origin trial feature list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ef-finch
Patch Set: Rebase; style fixes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/origin_trials/origin_trial_controller_unittest.cc
diff --git a/chrome/browser/origin_trials/origin_trial_controller_unittest.cc b/chrome/browser/origin_trials/origin_trial_controller_unittest.cc
index 36524cc3ec8974ac7974f3e73c95351a68b68378..e0d0321d8c2225e38ea00506cb1c07701e4b775b 100644
--- a/chrome/browser/origin_trials/origin_trial_controller_unittest.cc
+++ b/chrome/browser/origin_trials/origin_trial_controller_unittest.cc
@@ -14,6 +14,7 @@
const char kFieldTrialGroup[] = "TestGroup";
const char kNewPublicKey[] = "dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNA=";
+const char kNewDisabledFeatures[] = "Frobulate";
class OriginTrialControllerTest : public testing::Test {
protected:
@@ -59,7 +60,7 @@ TEST_F(OriginTrialControllerTest, EmptyFieldTrial) {
EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
}
-TEST_F(OriginTrialControllerTest, EmptyStringFieldTrial) {
+TEST_F(OriginTrialControllerTest, EmptyKeyFieldTrial) {
AddFieldTrial();
AddFieldTrialParam(OriginTrialController::kPublicKeyFieldName, "");
UpdateCommandLine();
@@ -74,3 +75,22 @@ TEST_F(OriginTrialControllerTest, FieldTrialUpdatesPublicKey) {
EXPECT_EQ(kNewPublicKey, command_line()->GetSwitchValueASCII(
switches::kOriginTrialPublicKey));
}
+
+TEST_F(OriginTrialControllerTest, EmptyDisabledFeaturesFieldTrial) {
+ AddFieldTrial();
+ AddFieldTrialParam(OriginTrialController::kDisabledFeaturesFieldName, "");
+ UpdateCommandLine();
+ EXPECT_FALSE(
+ command_line()->HasSwitch(switches::kOriginTrialDisabledFeatures));
+}
+
+TEST_F(OriginTrialControllerTest, FieldTrialUpdatesDisabledFeatures) {
+ AddFieldTrial();
+ AddFieldTrialParam(OriginTrialController::kDisabledFeaturesFieldName,
+ kNewDisabledFeatures);
+ UpdateCommandLine();
+ EXPECT_TRUE(
+ command_line()->HasSwitch(switches::kOriginTrialDisabledFeatures));
+ EXPECT_EQ(kNewDisabledFeatures, command_line()->GetSwitchValueASCII(
+ switches::kOriginTrialDisabledFeatures));
+}

Powered by Google App Engine
This is Rietveld 408576698