Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: chrome/browser/origin_trials/origin_trial_controller_unittest.cc

Issue 1741783002: Add disabled origin trial feature list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ef-finch
Patch Set: Rebase; style fixes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/origin_trials/origin_trial_controller.h" 5 #include "chrome/browser/origin_trials/origin_trial_controller.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "chrome/common/chrome_switches.h" 11 #include "chrome/common/chrome_switches.h"
12 #include "components/variations/variations_associated_data.h" 12 #include "components/variations/variations_associated_data.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 14
15 const char kFieldTrialGroup[] = "TestGroup"; 15 const char kFieldTrialGroup[] = "TestGroup";
16 const char kNewPublicKey[] = "dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNA="; 16 const char kNewPublicKey[] = "dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNA=";
17 const char kNewDisabledFeatures[] = "Frobulate";
17 18
18 class OriginTrialControllerTest : public testing::Test { 19 class OriginTrialControllerTest : public testing::Test {
19 protected: 20 protected:
20 OriginTrialControllerTest() { 21 OriginTrialControllerTest() {
21 field_trial_list_.reset( 22 field_trial_list_.reset(
22 new base::FieldTrialList(nullptr /* entropy provider */)); 23 new base::FieldTrialList(nullptr /* entropy provider */));
23 variations::testing::ClearAllVariationParams(); 24 variations::testing::ClearAllVariationParams();
24 } 25 }
25 26
26 void AddFieldTrial() { 27 void AddFieldTrial() {
(...skipping 25 matching lines...) Expand all
52 UpdateCommandLine(); 53 UpdateCommandLine();
53 EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey)); 54 EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
54 } 55 }
55 56
56 TEST_F(OriginTrialControllerTest, EmptyFieldTrial) { 57 TEST_F(OriginTrialControllerTest, EmptyFieldTrial) {
57 AddFieldTrial(); 58 AddFieldTrial();
58 UpdateCommandLine(); 59 UpdateCommandLine();
59 EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey)); 60 EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
60 } 61 }
61 62
62 TEST_F(OriginTrialControllerTest, EmptyStringFieldTrial) { 63 TEST_F(OriginTrialControllerTest, EmptyKeyFieldTrial) {
63 AddFieldTrial(); 64 AddFieldTrial();
64 AddFieldTrialParam(OriginTrialController::kPublicKeyFieldName, ""); 65 AddFieldTrialParam(OriginTrialController::kPublicKeyFieldName, "");
65 UpdateCommandLine(); 66 UpdateCommandLine();
66 EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey)); 67 EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
67 } 68 }
68 69
69 TEST_F(OriginTrialControllerTest, FieldTrialUpdatesPublicKey) { 70 TEST_F(OriginTrialControllerTest, FieldTrialUpdatesPublicKey) {
70 AddFieldTrial(); 71 AddFieldTrial();
71 AddFieldTrialParam(OriginTrialController::kPublicKeyFieldName, kNewPublicKey); 72 AddFieldTrialParam(OriginTrialController::kPublicKeyFieldName, kNewPublicKey);
72 UpdateCommandLine(); 73 UpdateCommandLine();
73 EXPECT_TRUE(command_line()->HasSwitch(switches::kOriginTrialPublicKey)); 74 EXPECT_TRUE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
74 EXPECT_EQ(kNewPublicKey, command_line()->GetSwitchValueASCII( 75 EXPECT_EQ(kNewPublicKey, command_line()->GetSwitchValueASCII(
75 switches::kOriginTrialPublicKey)); 76 switches::kOriginTrialPublicKey));
76 } 77 }
78
79 TEST_F(OriginTrialControllerTest, EmptyDisabledFeaturesFieldTrial) {
80 AddFieldTrial();
81 AddFieldTrialParam(OriginTrialController::kDisabledFeaturesFieldName, "");
82 UpdateCommandLine();
83 EXPECT_FALSE(
84 command_line()->HasSwitch(switches::kOriginTrialDisabledFeatures));
85 }
86
87 TEST_F(OriginTrialControllerTest, FieldTrialUpdatesDisabledFeatures) {
88 AddFieldTrial();
89 AddFieldTrialParam(OriginTrialController::kDisabledFeaturesFieldName,
90 kNewDisabledFeatures);
91 UpdateCommandLine();
92 EXPECT_TRUE(
93 command_line()->HasSwitch(switches::kOriginTrialDisabledFeatures));
94 EXPECT_EQ(kNewDisabledFeatures, command_line()->GetSwitchValueASCII(
95 switches::kOriginTrialDisabledFeatures));
96 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698