Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5309)

Unified Diff: chrome/common/origin_trials/origin_trial_key_manager.h

Issue 1741783002: Add disabled origin trial feature list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ef-finch
Patch Set: Separate the introduction of preference-persistence into a different CL Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/origin_trials/origin_trial_key_manager.h
diff --git a/chrome/common/origin_trials/origin_trial_key_manager.h b/chrome/common/origin_trials/origin_trial_key_manager.h
index e46e7be11f7d7622753970267a6e46dbcdb4e6b3..e1f03925548a458fc39a2eae354837f7f7462420 100644
--- a/chrome/common/origin_trials/origin_trial_key_manager.h
+++ b/chrome/common/origin_trials/origin_trial_key_manager.h
@@ -5,6 +5,7 @@
#ifndef CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_
#define CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_
+#include <set>
#include <string>
#include "base/macros.h"
@@ -21,11 +22,14 @@ class OriginTrialKeyManager {
bool SetPublicKeyFromASCIIString(const std::string& ascii_public_key);
base::StringPiece GetPublicKey() const;
+ bool SetDisabledFeatures(const std::string& disabled_feature_list);
+ bool IsFeatureDisabled(base::StringPiece feature);
Sorin Jianu 2016/06/07 17:20:24 Most likely, StringPiece can be forward declared.
iclelland 2016/06/08 13:37:56 I don't think so -- it's a typedef to a template;
static void RegisterPrefs(PrefRegistrySimple* registry);
private:
std::string public_key_;
+ std::set<std::string> disabled_features_;
DISALLOW_COPY_AND_ASSIGN(OriginTrialKeyManager);
};

Powered by Google App Engine
This is Rietveld 408576698