Add disabled origin trial feature list

chrome/common/origin_trials/origin_trial_key_manager.h

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_
 #define CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_
 
+#include <set>
 #include <string>
 
 #include "base/macros.h"
 #include "base/strings/string_piece.h"
 
 class PrefRegistrySimple;
 
 // This class is instantiated on the main/ui thread, but its methods can be
 // accessed from any thread.
 class OriginTrialKeyManager {

[chasej, 2016/06/07 15:51:31]

This class now does more than manage keys. I think a rename might be in order.

[iclelland, 2016/06/08 15:38:52]

Renamed in refactor-CL https://codereview.chromium.org/2049783002

  public:
   OriginTrialKeyManager();
   ~OriginTrialKeyManager();
 
   bool SetPublicKeyFromASCIIString(const std::string& ascii_public_key);
   base::StringPiece GetPublicKey() const;
+  bool SetDisabledFeatures(const std::string& disabled_feature_list);
+  bool IsFeatureDisabled(base::StringPiece feature);

[Sorin Jianu, 2016/06/07 17:20:24]

Most likely, StringPiece can be forward declared.

[iclelland, 2016/06/08 13:37:56]

I don't think so -- it's a typedef to a template; we could forward declare the
BasicStringPiece template class here, I guess, and then redefine the typedef,
but I don't see that anywhere else in the codebase.

 
   static void RegisterPrefs(PrefRegistrySimple* registry);
 
  private:
   std::string public_key_;
+  std::set<std::string> disabled_features_;
 
   DISALLOW_COPY_AND_ASSIGN(OriginTrialKeyManager);
 };
 
 #endif  // CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_