Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 1741623003: [api] Speed up template instantiation cache a bit. (Closed)

Created:
4 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Speed up template instantiation cache a bit. The keys are always positive integers, so use an UnseededNumberDictionary to store them instead of an ObjectHashTable R=bmeurer@chromium.org Committed: https://crrev.com/6a7e86613411965bb43eba7ee609d37dce6881fa Cr-Commit-Position: refs/heads/master@{#34325}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M src/api-natives.cc View 3 chunks +15 lines, -8 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 3 chunks +12 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
jochen (gone - plz use gerrit)
4 years, 10 months ago (2016-02-26 11:15:10 UTC) #1
Benedikt Meurer
You no compile... but otherwise LGTM.
4 years, 10 months ago (2016-02-26 11:55:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741623003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741623003/20001
4 years, 10 months ago (2016-02-26 12:04:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-26 12:23:37 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 12:23:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a7e86613411965bb43eba7ee609d37dce6881fa
Cr-Commit-Position: refs/heads/master@{#34325}

Powered by Google App Engine
This is Rietveld 408576698