Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: test/cctest/test-api.cc

Issue 1741623003: [api] Speed up template instantiation cache a bit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index e9b2fce7f051ace5ded179f59d73dbdebb73bc60..60f2c12bc9f4d64dbb77c3a16a8a7fd0062b241b 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -22475,7 +22475,8 @@ THREADED_TEST(FunctionNew) {
->serial_number()),
i_isolate);
auto cache = i_isolate->template_instantiations_cache();
- CHECK(cache->Lookup(serial_number)->IsTheHole());
+ CHECK(cache->FindEntry(static_cast<uint32_t>(serial_number->value())) ==
+ i::UnseededNumberDictionary::kNotFound);
// Verify that each Function::New creates a new function instance
Local<Object> data2 = v8::Object::New(isolate);
function_new_expected_env = data2;
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698