Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 174153004: mesa compile fixes for Clang / VS2013 (Closed)

Created:
6 years, 10 months ago by hans
Modified:
6 years, 10 months ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/mesa.git@master
Visibility:
Public.

Description

mesa compile fixes for Clang / VS2013 These functions are all defined in the standard library now, and Clang warns about non-static declaration followed by static declaration. BUG=82385 Committed: http://src.chromium.org/viewvc/chrome?revision=252594&view=revision

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/gallium/auxiliary/util/u_math.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/mesa/main/imports.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hans
Please take a look.
6 years, 10 months ago (2014-02-21 03:27:47 UTC) #1
scottmg
lgtm I guess update README.chromium with this information in the CL to roll DEPS.
6 years, 10 months ago (2014-02-21 04:04:25 UTC) #2
hans
The CQ bit was checked by hans@chromium.org
6 years, 10 months ago (2014-02-21 17:51:03 UTC) #3
hans
Committed manually in r252594.
6 years, 10 months ago (2014-02-21 18:12:12 UTC) #4
Nico
Is there an upstream bug for this?
6 years, 10 months ago (2014-02-21 18:58:25 UTC) #5
hans
6 years, 10 months ago (2014-02-21 19:22:23 UTC) #6
Message was sent while issue was closed.
On 2014/02/21 18:58:25, Nico (vacation Feb 24 - 29) wrote:
> Is there an upstream bug for this?

There is now: https://bugs.freedesktop.org/show_bug.cgi?id=75336

Powered by Google App Engine
This is Rietveld 408576698