Issue 17415007: Get rid of RequestRegistry (part 3): remove Drive path from request objects.

Issue 17415007: Get rid of RequestRegistry (part 3): remove Drive path from request objects. (Closed)

Created:
7 years, 6 months ago by kinaba

Modified:
7 years, 6 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get rid of RequestRegistry (part 3): remove Drive path from request objects. They are used as an identifier to cancel each operation, but the cancellation feature has gone from RequestRegistry. At the same time, re-enabling the unit tests that I should have done in r206970. BUG=164098 R=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207312

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -159 lines)			Patch
M	chrome/browser/drive/drive_api_service.cc	View		5 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/drive/gdata_wapi_service.cc	View		5 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/google_apis/base_requests.h	View		9 chunks	+3 lines, -26 lines	0 comments	Download
M	chrome/browser/google_apis/base_requests.cc	View		10 chunks	+3 lines, -42 lines	0 comments	Download
M	chrome/browser/google_apis/base_requests_server_unittest.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests.h	View	1	4 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests.cc	View		7 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests_unittest.cc	View		17 chunks	+0 lines, -20 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_requests.h	View	1	4 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_requests.cc	View		7 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_requests_unittest.cc	View		18 chunks	+1 line, -21 lines	0 comments	Download
M	chrome/browser/google_apis/request_registry.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/google_apis/request_registry.cc	View	1 2	1 chunk	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kinaba

ptal (depending on https://codereview.chromium.org/17385023/)

7 years, 6 months ago (2013-06-19 03:50:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17415007/3002

7 years, 6 months ago (2013-06-19 05:36:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17415007/40001

7 years, 6 months ago (2013-06-19 09:55:00 UTC) #4

kinaba

7 years, 6 months ago (2013-06-20 03:54:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r207312 (presubmit successful).

Expand Messages | Collapse Messages