Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 17385023: Get rid of RequestRegistry (part 2): remove cancellation methods. (Closed)

Created:
7 years, 6 months ago by kinaba
Modified:
7 years, 6 months ago
Reviewers:
satorux1, tzik
CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Get rid of RequestRegistry (part 2): remove cancellation methods. * CancelForFilePath is used only from drive::JobScheduler, and is now 100% covered by the new, base::Callback based cancellation. * I guess CancelAll had been used just for satisfing the DCHECK in ~RequestRegistry. But it's not needed. The requests are discarded without problem in the destructor. BUG=164098 R=satorux@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207185

Patch Set 1 #

Patch Set 2 : Remove unused methods in RequestRegisty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -108 lines) Patch
M chrome/browser/chromeos/contacts/gdata_contacts_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/drive/drive_api_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/drive/mock_drive_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/request_registry.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/google_apis/request_registry.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/google_apis/request_sender.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/request_sender.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive/api_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
+tzik: c/b/sync_file_system +satorux: c/b/contacts and everything else
7 years, 6 months ago (2013-06-19 03:14:46 UTC) #1
tzik
lgtm
7 years, 6 months ago (2013-06-19 03:35:05 UTC) #2
satorux1
LGTM
7 years, 6 months ago (2013-06-19 03:39:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17385023/7001
7 years, 6 months ago (2013-06-19 03:45:04 UTC) #4
kinaba
7 years, 6 months ago (2013-06-19 05:23:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r207185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698