Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1759)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1741393002: [wasm] Rename ExprBoolNot to ExprI32Eqz. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
bradnelson, bradn, binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Rename ExprBoolNot to ExprI32Eqz. R=bradnelson@chromium.org, binji@chromium.org BUG= Committed: https://crrev.com/91802542d509a014edd03d5b32e831016a90e859 Cr-Commit-Position: refs/heads/master@{#34350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/compiler/wasm-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wasm/asm-wasm-builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-opcodes.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
titzer
4 years, 9 months ago (2016-02-28 15:12:42 UTC) #1
bradn
lgtm
4 years, 9 months ago (2016-02-28 18:57:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741393002/1
4 years, 9 months ago (2016-02-28 18:57:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-28 19:01:39 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-28 19:02:36 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/91802542d509a014edd03d5b32e831016a90e859
Cr-Commit-Position: refs/heads/master@{#34350}

Powered by Google App Engine
This is Rietveld 408576698