src/wasm/asm-wasm-builder.cc - Issue 1741393002: [wasm] Rename ExprBoolNot to ExprI32Eqz.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/asm-wasm-builder.cc

Issue 1741393002: [wasm] Rename ExprBoolNot to ExprI32Eqz. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/asm-wasm-builder.cc

diff --git a/src/wasm/asm-wasm-builder.cc b/src/wasm/asm-wasm-builder.cc

index abb69d5678565b5ebe91efa18f98c1dc1365e672..bf9ffde0b88f0adae3929603b05f27a1ab7a575d 100644

--- a/src/wasm/asm-wasm-builder.cc

+++ b/src/wasm/asm-wasm-builder.cc

@@ -318,7 +318,7 @@ class AsmWasmBuilderImpl : public AstVisitor {

if (stmt->cond() != nullptr) {

block_size_++;

current_function_builder_->Emit(kExprIf);

- current_function_builder_->Emit(kExprBoolNot);

+ current_function_builder_->Emit(kExprI32Eqz);

RECURSE(Visit(stmt->cond()));

current_function_builder_->EmitWithU8(kExprBr, 1);

current_function_builder_->Emit(kExprNop);

@@ -1045,7 +1045,7 @@ class AsmWasmBuilderImpl : public AstVisitor {

switch (expr->op()) {

case Token::NOT: {

DCHECK_EQ(kAstI32, TypeOf(expr->expression()));

- current_function_builder_->Emit(kExprBoolNot);

+ current_function_builder_->Emit(kExprI32Eqz);

break;

}

default:

« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/wasm/wasm-macro-gen.h » ('j') | no next file with comments »