Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 17412: Experimental: a quick hack to allow different live values to flow down... (Closed)

Created:
11 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Experimental: a quick hack to allow different live values to flow down the two CFG edges at a branch. The values on the frame flow to the labeled block, and the values on the frame and all live non-frame references (results) flow to the fall-through. The hack is to save and restore non-frame references whenever the code generator's frame is switched. Once "MakeMergable" goes away and the merge code is moved from the source to the destination block, this will be unnecessary. Committed: http://code.google.com/p/v8/source/detail?r=1048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -13 lines) Patch
M src/codegen-ia32.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/codegen-ia32.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M src/jump-target-ia32.cc View 4 chunks +23 lines, -5 lines 0 comments Download
M src/register-allocator-ia32.h View 3 chunks +18 lines, -0 lines 0 comments Download
M src/register-allocator-ia32.cc View 1 chunk +17 lines, -1 line 0 comments Download
M src/virtual-frame-ia32.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
This is unpleasant from an API, an engineering, and a moral standpoint. It is temporary.
11 years, 11 months ago (2009-01-08 12:12:37 UTC) #1
William Hesse
11 years, 11 months ago (2009-01-08 12:28:27 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698