Issue 174119: Disable playback controls if audio/video element has errored.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174119: Disable playback controls if audio/video element has errored. (Closed)

Created:
11 years, 4 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Disable playback controls if audio/video element has errored. TEST=load an audio/video with an unsupported input, then right click on it.. the playback control items should be disabled BUG=19740

Patch Set 1 #

Total comments: 3

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	webkit/glue/context_menu_client_impl.cc	View		3 chunks	+4 lines, -1 line	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

awong

http://codereview.chromium.org/174119/diff/1/2 File webkit/glue/context_menu_client_impl.cc (right): http://codereview.chromium.org/174119/diff/1/2#newcode21 Line 21: #include "MediaError.h" Do you need to include MediaError?

11 years, 4 months ago (2009-08-20 18:33:54 UTC) #2

scherkus (not reviewing)

11 years, 4 months ago (2009-08-20 18:50:24 UTC) #3

awong

11 years, 4 months ago (2009-08-20 18:57:52 UTC) #4

LGTM

http://codereview.chromium.org/174119/diff/1/2
File webkit/glue/context_menu_client_impl.cc (right):

http://codereview.chromium.org/174119/diff/1/2#newcode21
Line 21: #include "MediaError.h"
On 2009/08/20 18:50:24, scherkus wrote:
> On 2009/08/20 18:33:54, awong wrote:
> > Do you  need to include MediaError?
> 
> HTMLMediaElement::error() returns PassRefPtr<MediaError>.  The compiler dies
> when attempting to resolve that class.


Ah...makes sense.  <insert grumbling about making a template that requires a
fully defined type to do something that's not necessary>

Expand Messages | Collapse Messages