Disable playback controls if audio/video element has errored.

webkit/glue/context_menu_client_impl.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "base/compiler_specific.h"
 
 MSVC_PUSH_WARNING_LEVEL(0);
 #include "ContextMenu.h"
 #include "Document.h"
 #include "DocumentLoader.h"
 #include "Editor.h"
 #include "EventHandler.h"
 #include "FrameLoader.h"
 #include "FrameView.h"
 #include "HitTestResult.h"
 #include "HTMLMediaElement.h"
 #include "HTMLNames.h"
 #include "KURL.h"
+#include "MediaError.h"

[awong, 2009/08/20 18:33:54]

Do you  need to include MediaError?

[scherkus (not reviewing), 2009/08/20 18:50:24]

HTMLMediaElement::error() returns PassRefPtr<MediaError>.  The compiler dies
when attempting to resolve that class.

[awong, 2009/08/20 18:57:52]

Ah...makes sense.  <insert grumbling about making a template that requires a
fully defined type to do something that's not necessary>

 #include "Widget.h"
 MSVC_POP_WARNING();
 #undef LOG
 
 #include "webkit/glue/context_menu_client_impl.h"
 
 #include "base/string_util.h"
 #include "webkit/api/public/WebURL.h"
 #include "webkit/api/public/WebURLResponse.h"
 #include "webkit/glue/context_menu.h"
@@ skipping 153 matching lines @@
     // We know that if absoluteMediaURL() is not empty, then this is a media
     // element.
     WebCore::HTMLMediaElement* media_element =
         static_cast<WebCore::HTMLMediaElement*>(r.innerNonSharedNode());
     if (media_element->hasTagName(WebCore::HTMLNames::videoTag)) {
       node_type.type |= ContextNodeType::VIDEO;
     } else if (media_element->hasTagName(WebCore::HTMLNames::audioTag)) {
       node_type.type |= ContextNodeType::AUDIO;
     }
 
+    if (media_element->error()) {
+      media_params.player_state |= ContextMenuMediaParams::IN_ERROR;
+    }
     if (media_element->paused()) {
       media_params.player_state |= ContextMenuMediaParams::PAUSED;
     }
     if (media_element->muted()) {
       media_params.player_state |= ContextMenuMediaParams::MUTED;
     }
     if (media_element->loop()) {
       media_params.player_state |= ContextMenuMediaParams::LOOP;
     }
     if (media_element->supportsSave()) {
       media_params.player_state |= ContextMenuMediaParams::CAN_SAVE;
     }
-    // TODO(ajwong): Report error states in the media player.
   }
 
   // If it's not a link, an image, a media element, or an image/media link,
   // show a selection menu or a more generic page menu.
   std::wstring selection_text_string;
   std::wstring misspelled_word_string;
   GURL frame_url;
   GURL page_url;
   std::string security_info;
 
@@ skipping 106 matching lines @@
 
 bool ContextMenuClientImpl::shouldIncludeInspectElementItem() {
     return false;  // TODO(jackson): Eventually include the inspector context menu item
 }
 
 #if defined(OS_MACOSX)
 void ContextMenuClientImpl::searchWithSpotlight() {
   // TODO(pinkerton): write this
 }
 #endif