Switch back to open image in new tab where applicable.

Switch back to open image in new tab where applicable.

open image will remain in CCT as that tries to prevent new
tab creation

BUG=589275
Committed: https://crrev.com/4dba7838c14fff4e36c49045a8c4c2bf72b64b18
Cr-Commit-Position: refs/heads/master@{#379877}

[Ted C, 2016-02-26 23:06:46]

tedchoc@chromium.org changed reviewers:
+ newt@chromium.org

[Ted C, 2016-02-26 23:06:47]

PTAL

A partial revert of:
https://codereview.chromium.org/1404793006

[newt (away), 2016-02-27 02:01:14]

https://codereview.chromium.org/1741153002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/1741153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:230:
if (mDelegate.canLoadOriginalImage()) {
I don't understand this check. Why should we hide the "open image in new tab"
option just because the image was loaded over the data compression proxy?

https://codereview.chromium.org/1741153002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/1741153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:198:
boolean isSpdyProxyEnabledForUrl(String url) {
why no longer private?

[Ted C, 2016-03-07 18:50:49]

https://codereview.chromium.org/1741153002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/1741153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:230:
if (mDelegate.canLoadOriginalImage()) {
On 2016/02/27 02:01:14, newt wrote:
> I don't understand this check. Why should we hide the "open image in new tab"
> option just because the image was loaded over the data compression proxy?

Looks like I need to add back open [original] image in new tab.

Done

https://codereview.chromium.org/1741153002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/1741153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:198:
boolean isSpdyProxyEnabledForUrl(String url) {
On 2016/02/27 02:01:14, newt wrote:
> why no longer private?

no good reason...over zealous revert of the other change

[newt (away), 2016-03-07 23:37:56]

lgtm :)

[Ted C, 2016-03-07 23:38:43]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2016-03-07 23:39:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1741153002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1741153002/40001

[commit-bot: I haz the power, 2016-03-08 01:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 01:12:44]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ted C, 2016-03-08 18:23:25]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-03-08 18:23:26]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1741153002/#ps60001
(title: "Fix tests")

[commit-bot: I haz the power, 2016-03-08 18:23:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1741153002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1741153002/60001

[commit-bot: I haz the power, 2016-03-08 19:08:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-08 19:09:51]

Description was changed from

==========
Switch back to open image in new tab where applicable.

open image will remain in CCT as that tries to prevent new
tab creation

BUG=589275
==========

to

==========
Switch back to open image in new tab where applicable.

open image will remain in CCT as that tries to prevent new
tab creation

BUG=589275

Committed: https://crrev.com/4dba7838c14fff4e36c49045a8c4c2bf72b64b18
Cr-Commit-Position: refs/heads/master@{#379877}
==========

[commit-bot: I haz the power, 2016-03-08 19:09:52]

Patchset 4 (id:??) landed as
https://crrev.com/4dba7838c14fff4e36c49045a8c4c2bf72b64b18
Cr-Commit-Position: refs/heads/master@{#379877}

[Benoit L, 2016-03-09 12:44:34]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1773423002/ by lizeb@chromium.org.

The reason for reverting is: Suspected CL for test breakages:
org.chromium.chrome.browser.contextmenu.ContextMenuTest#testLongPressOnImage
org.chromium.chrome.browser.contextmenu.ContextMenuTest#testLongPressOnImageLink

on downstream occam-svelte and android-one..