chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java - Issue 1741153002: Switch back to open image in new tab where applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 1741153002: Switch back to open image in new tab where applicable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/menu/chrome_context_menu.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItemDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

index 4e6240da8a8219e941ee6865e8be914da1055caf..93e88fc2f0df6290014c719b2392b7732e2bd90a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

@@ -47,7 +47,7 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {

R.id.contextmenu_open_in_incognito_tab,

R.id.contextmenu_save_link_as,

R.id.contextmenu_load_original_image,

- R.id.contextmenu_open_image,

+ R.id.contextmenu_open_image_in_new_tab,

R.id.contextmenu_search_by_image,

};

@@ -77,6 +77,7 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {

static final int ACTION_SAVE_LINK = 5;

static final int ACTION_SAVE_IMAGE = 6;

static final int ACTION_OPEN_IMAGE = 7;

+ static final int ACTION_OPEN_IMAGE_IN_NEW_TAB = 8;

static final int ACTION_SEARCH_BY_IMAGE = 11;

static final int ACTION_LOAD_IMAGES = 12;

static final int ACTION_LOAD_ORIGINAL_IMAGE = 13;

@@ -279,6 +280,9 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {

} else if (itemId == R.id.contextmenu_open_image) {

ContextMenuUma.record(params, ContextMenuUma.ACTION_OPEN_IMAGE);

mDelegate.onOpenImageUrl(params.getSrcUrl(), params.getReferrer());

+ } else if (itemId == R.id.contextmenu_open_image_in_new_tab) {

+ ContextMenuUma.record(params, ContextMenuUma.ACTION_OPEN_IMAGE_IN_NEW_TAB);

+ mDelegate.onOpenImageInNewTab(params.getSrcUrl(), params.getReferrer());

} else if (itemId == R.id.contextmenu_load_images) {

ContextMenuUma.record(params, ContextMenuUma.ACTION_LOAD_IMAGES);

DataReductionProxyUma.dataReductionProxyLoFiUIAction(