RTCPeerConnection.generateCertificate: Optionally specify expiration.

content/renderer/media/peer_connection_identity_store.h

Index: content/renderer/media/peer_connection_identity_store.h
diff --git a/content/renderer/media/peer_connection_identity_store.h b/content/renderer/media/peer_connection_identity_store.h
index 35d99c5a6c4766b665d669c19bfc7c7c59e142c0..cdd0ec29836e145504aa9f1f3e78c3d98a65de15 100644
--- a/content/renderer/media/peer_connection_identity_store.h
+++ b/content/renderer/media/peer_connection_identity_store.h
@@ -9,6 +9,7 @@
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_checker.h"
 #include "third_party/webrtc/api/dtlsidentitystore.h"
+#include "third_party/webrtc/base/optional.h"
 #include "url/gurl.h"
 
 namespace content {
@@ -27,7 +28,8 @@ class PeerConnectionIdentityStore
 
   // webrtc::DtlsIdentityStoreInterface override;
   void RequestIdentity(
-      rtc::KeyParams key_params,
+      const rtc::KeyParams& key_params,
+      const rtc::Optional<uint64_t>& expires_ms,

[Ryan Sleevi, 2016/03/08 17:06:10]

This seems like a clear violation, through creative templating, of the Chromium
(and Google) style guide with respect to Overloads.

Is there a reason WebRTC isn't following the Google style guide in letter and in
spirit?

[hbos_chromium, 2016/04/13 17:03:08]

You're referring to two RequestIdentity signatures, same name but different
parameters, with default implementation to call the other signature. There is
the "old" signature and the "new" signature. There was only ever meant to be one
signature, but because webrtc and chromium are different repos, both signatures
exist for a transition period (as to not break chromium by landing a webrtc
change that changes the signature). Incidentally this work was put on hold but
it's being picked up again, moving forward there will only be this version of
RequestIdentity, but the other version can't be removed until this change lands.

       const rtc::scoped_refptr<webrtc::DtlsIdentityRequestObserver>& observer)
           override;