RTCPeerConnection.generateCertificate: Optionally specify expiration.

content/renderer/media/peer_connection_identity_store.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_PEER_CONNECTION_IDENTITY_STORE_H_
 #define CONTENT_RENDERER_MEDIA_PEER_CONNECTION_IDENTITY_STORE_H_
 
 #include "base/macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_checker.h"
 #include "third_party/webrtc/api/dtlsidentitystore.h"
+#include "third_party/webrtc/base/optional.h"
 #include "url/gurl.h"
 
 namespace content {
 
 // This class is associated with a peer connection and handles WebRTC DTLS
 // identity requests by delegating to the per-renderer WebRTCIdentityProxy.
 class PeerConnectionIdentityStore
     : public webrtc::DtlsIdentityStoreInterface {
  public:
   PeerConnectionIdentityStore(
       const scoped_refptr<base::SingleThreadTaskRunner>& main_thread,
       const scoped_refptr<base::SingleThreadTaskRunner>& signaling_thread,
       const GURL& origin,
       const GURL& first_party_for_cookies);
   ~PeerConnectionIdentityStore() override;
 
   // webrtc::DtlsIdentityStoreInterface override;
   void RequestIdentity(
-      rtc::KeyParams key_params,
+      const rtc::KeyParams& key_params,
+      const rtc::Optional<uint64_t>& expires_ms,

[Ryan Sleevi, 2016/03/08 17:06:10]

This seems like a clear violation, through creative templating, of the Chromium
(and Google) style guide with respect to Overloads.

Is there a reason WebRTC isn't following the Google style guide in letter and in
spirit?

[hbos_chromium, 2016/04/13 17:03:08]

You're referring to two RequestIdentity signatures, same name but different
parameters, with default implementation to call the other signature. There is
the "old" signature and the "new" signature. There was only ever meant to be one
signature, but because webrtc and chromium are different repos, both signatures
exist for a transition period (as to not break chromium by landing a webrtc
change that changes the signature). Incidentally this work was put on hold but
it's being picked up again, moving forward there will only be this version of
RequestIdentity, but the other version can't be removed until this change lands.

       const rtc::scoped_refptr<webrtc::DtlsIdentityRequestObserver>& observer)
           override;
 
  private:
   const scoped_refptr<base::SingleThreadTaskRunner> main_thread_;
   const scoped_refptr<base::SingleThreadTaskRunner> signaling_thread_;
   const GURL url_;
   const GURL first_party_for_cookies_;
 
   DISALLOW_COPY_AND_ASSIGN(PeerConnectionIdentityStore);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_PEER_CONNECTION_IDENTITY_STORE_H_