[Offline pages] Adding the status icon to the OIB

chrome/android/java/res/layout/website_settings.xml

Index: chrome/android/java/res/layout/website_settings.xml
diff --git a/chrome/android/java/res/layout/website_settings.xml b/chrome/android/java/res/layout/website_settings.xml
index 9cc5ee33953a023664cfbc8e8e92d02fe8e895a6..729f73d1d90e8d464b9e280ab019d6c983bddb4d 100644
--- a/chrome/android/java/res/layout/website_settings.xml
+++ b/chrome/android/java/res/layout/website_settings.xml
@@ -20,16 +20,34 @@
         android:paddingEnd="@dimen/website_settings_popup_padding_sides"
         android:paddingStart="@dimen/website_settings_popup_padding_sides" >
 
-        <view class="org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup$ElidedUrlTextView"
-            android:id="@+id/website_settings_url"
+        <LinearLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:ellipsize="end"
-            android:lineSpacingExtra="6dp"
-            android:paddingTop="16dp"
-            android:textAlignment="viewStart"
-            android:textColor="@color/url_emphasis_default_text"
-            android:textSize="16sp"/>
+            android:orientation="horizontal"
+            android:paddingTop="16dp" >
+
+            <ImageView android:id="@+id/status_icon"

[Ted C, 2016/02/26 20:57:37]

Instead of adding the ImageView, can you try calling:
ApiCompatibilityUtils#setCompoundDrawablesRelative

Along with:
http://developer.android.com/reference/android/widget/TextView.html#setCompou...

I suspect it would center the asset vs aligning it to the top, which is probably
not what you want.  But it would be better than adding the linearlayout.  But if
it doesn't work then this is fine.

Also, we should call this offline_icon for now.

[fgorski, 2016/02/26 22:33:26]

Renamed. I tried the content drawables, but that indeed centers the icon on the
left and does not allow to specify content description. 
We want to appear on top of the dialog. Linear Layout seems better for that.

+                style="@style/LocationBarButton"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_gravity="start|top"
+                android:paddingEnd="12dp"
+                android:src="@drawable/offline_bolt"
+                android:alpha="0.54"

[Ted C, 2016/02/26 20:57:37]

do you need the alpha or the new assets negate the need for this?

[fgorski, 2016/02/26 22:33:26]

Done.

+                android:visibility="gone"
+                android:contentDescription="@string/accessibility_toolbar_btn_site_info" />

[Ted C, 2016/02/26 20:57:37]

we should have a specific accessibility string.  this should say something about
offline instead of a generic site info string.

[fgorski, 2016/02/26 22:33:26]

Done.

+                
+            <view class="org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup$ElidedUrlTextView"
+                android:id="@+id/website_settings_url"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:ellipsize="end"
+                android:lineSpacingExtra="6dp"
+                android:textAlignment="viewStart"
+                android:textColor="@color/url_emphasis_default_text"
+                android:textSize="16sp"/>
+
+        </LinearLayout>
 
         <TextView
             android:id="@+id/website_settings_connection_message"