[Offline pages] Adding the status icon to the OIB

chrome/android/java/res/layout/website_settings.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!--
    Copyright 2013 The Chromium Authors. All rights reserved.
 
    Use of this source code is governed by a BSD-style license that can be
    found in the LICENSE file.
 -->
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:paddingBottom="8dp"
     android:background="#ffffff"
     android:orientation="vertical" >
 
     <LinearLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:orientation="vertical"
         android:paddingBottom="12dp"
         android:paddingEnd="@dimen/website_settings_popup_padding_sides"
         android:paddingStart="@dimen/website_settings_popup_padding_sides" >
 
-        <view class="org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup$ElidedUrlTextView"
-            android:id="@+id/website_settings_url"
+        <LinearLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:ellipsize="end"
-            android:lineSpacingExtra="6dp"
-            android:paddingTop="16dp"
-            android:textAlignment="viewStart"
-            android:textColor="@color/url_emphasis_default_text"
-            android:textSize="16sp"/>
+            android:orientation="horizontal"
+            android:paddingTop="16dp" >
+
+            <ImageView android:id="@+id/status_icon"

[Ted C, 2016/02/26 20:57:37]

Instead of adding the ImageView, can you try calling:
ApiCompatibilityUtils#setCompoundDrawablesRelative

Along with:
http://developer.android.com/reference/android/widget/TextView.html#setCompou...

I suspect it would center the asset vs aligning it to the top, which is probably
not what you want.  But it would be better than adding the linearlayout.  But if
it doesn't work then this is fine.

Also, we should call this offline_icon for now.

[fgorski, 2016/02/26 22:33:26]

Renamed. I tried the content drawables, but that indeed centers the icon on the
left and does not allow to specify content description. 
We want to appear on top of the dialog. Linear Layout seems better for that.

+                style="@style/LocationBarButton"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_gravity="start|top"
+                android:paddingEnd="12dp"
+                android:src="@drawable/offline_bolt"
+                android:alpha="0.54"

[Ted C, 2016/02/26 20:57:37]

do you need the alpha or the new assets negate the need for this?

[fgorski, 2016/02/26 22:33:26]

Done.

+                android:visibility="gone"
+                android:contentDescription="@string/accessibility_toolbar_btn_site_info" />

[Ted C, 2016/02/26 20:57:37]

we should have a specific accessibility string.  this should say something about
offline instead of a generic site info string.

[fgorski, 2016/02/26 22:33:26]

Done.

+                
+            <view class="org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup$ElidedUrlTextView"
+                android:id="@+id/website_settings_url"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:ellipsize="end"
+                android:lineSpacingExtra="6dp"
+                android:textAlignment="viewStart"
+                android:textColor="@color/url_emphasis_default_text"
+                android:textSize="16sp"/>
+
+        </LinearLayout>
 
         <TextView
             android:id="@+id/website_settings_connection_message"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:lineSpacingExtra="3dp"
             android:paddingTop="8dp"
             android:textColor="@color/website_settings_popup_text"
             android:textSize="14sp" />
     </LinearLayout>
@@ skipping 14 matching lines @@
         android:layout_gravity="end"
         android:layout_marginEnd="@dimen/website_settings_popup_padding_sides"
         android:layout_marginStart="@dimen/website_settings_popup_padding_sides"
         android:layout_marginTop="8dp"
         android:paddingEnd="@dimen/website_settings_popup_button_padding_sides"
         android:paddingStart="@dimen/website_settings_popup_button_padding_sides"
         android:text="@string/page_info_site_settings_button"
         android:textColor="@color/light_active_color"
         style="@style/ButtonCompatBorderless" />
 </LinearLayout>