Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 1739913003: Start work to remove the context manager callbacks (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -26 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +11 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 5 chunks +8 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-26 19:37:37 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-26 20:31:02 UTC) #3
Paul Berry
lgtm
4 years, 10 months ago (2016-02-26 20:43:33 UTC) #4
Brian Wilkerson
4 years, 10 months ago (2016-02-26 21:11:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c2afc8d09fe8b1ceca27dae000fcc94d6761ed6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698