Start work to remove the context manager callbacks

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:core' hide Resource;
 import 'dart:math' show max;
@@ skipping 262 matching lines @@
   /**
    * If the "analysis.analyzedFiles" notification is currently being subscribed
    * to (see [generalAnalysisServices]), and at least one such notification has
    * been sent since the subscription was enabled, the set of analyzed files
    * that was delivered in the most recently sent notification.  Otherwise
    * `null`.
    */
   Set<String> prevAnalyzedFiles;
 
   /**
-   * The default options used to create new analysis contexts.
+   * The default options used to create new analysis contexts. This object is
+   * also referenced by the ContextManager.
    */
-  AnalysisOptionsImpl defaultContextOptions = new AnalysisOptionsImpl();
+  final AnalysisOptionsImpl defaultContextOptions = new AnalysisOptionsImpl();
 
   /**
    * The controller for sending [ContextsChangedEvent]s.
    */
   StreamController<ContextsChangedEvent> _onContextsChangedController =
       new StreamController<ContextsChangedEvent>.broadcast();
 
   /**
    * Initialize a newly created server to receive requests from and send
    * responses to the given [channel].
@@ skipping 11 matching lines @@
       this.serverPlugin,
       this.options,
       this.defaultSdkCreator,
       this.instrumentationService,
       {ResolverProvider packageResolverProvider: null,
       EmbeddedResolverProvider embeddedResolverProvider: null,
       this.rethrowExceptions: true})
       : index = _index,
         searchEngine = _index != null ? createSearchEngine(_index) : null {
     _performance = performanceDuringStartup;
+    defaultContextOptions.incremental = true;
+    defaultContextOptions.incrementalApi =
+        options.enableIncrementalResolutionApi;
+    defaultContextOptions.incrementalValidation =
+        options.enableIncrementalResolutionValidation;
+    defaultContextOptions.generateImplicitErrors = false;
     operationQueue = new ServerOperationQueue();
     contextManager = new ContextManagerImpl(
         resourceProvider,
         packageResolverProvider,
         embeddedResolverProvider,
         packageMapProvider,
-        instrumentationService);
+        instrumentationService,
+        defaultContextOptions);
     ServerContextManagerCallbacks contextManagerCallbacks =
         new ServerContextManagerCallbacks(this, resourceProvider);
     contextManager.callbacks = contextManagerCallbacks;
-    defaultContextOptions.incremental = true;
-    defaultContextOptions.incrementalApi =
-        options.enableIncrementalResolutionApi;
-    defaultContextOptions.incrementalValidation =
-        options.enableIncrementalResolutionValidation;
-    defaultContextOptions.generateImplicitErrors = false;
     _noErrorNotification = options.noErrorNotification;
     AnalysisEngine.instance.logger = new AnalysisLogger(this);
     _onAnalysisStartedController = new StreamController.broadcast();
     _onFileAnalyzedController = new StreamController.broadcast();
     _onPriorityChangeController =
         new StreamController<PriorityChangeEvent>.broadcast();
     running = true;
     onAnalysisStarted.first.then((_) {
       onAnalysisComplete.then((_) {
         performanceAfterStartup = new ServerPerformance();
@@ skipping 1131 matching lines @@
           AnalysisEngine.instance.logger.logError(
               'Invalid glob pattern: "$pattern"',
               new CaughtException(exception, stackTrace));
         }
       }
     }
     return _analyzedFilesGlobs;
   }
 
   @override
-  AnalysisOptions get defaultAnalysisOptions =>
-      analysisServer.defaultContextOptions;
-
-  @override
   AnalysisContext addContext(
       Folder folder, AnalysisOptions options, FolderDisposition disposition) {
     InternalAnalysisContext context =
         AnalysisEngine.instance.createAnalysisContext();
     context.contentCache = analysisServer.overlayState;
     analysisServer.folderMap[folder] = context;
     _locateEmbedderYamls(context, disposition);
     context.sourceFactory =
         _createSourceFactory(context, options, disposition, folder);
     context.analysisOptions = options;
@@ skipping 229 matching lines @@
   /**
    * The [PerformanceTag] for time spent in server request handlers.
    */
   static PerformanceTag serverRequests = new PerformanceTag('serverRequests');
 
   /**
    * The [PerformanceTag] for time spent in split store microtasks.
    */
   static PerformanceTag splitStore = new PerformanceTag('splitStore');
 }