Use TextDecoder instead of JSZip.utils.transformTo in GzipImporter

Use TextDecoder instead of JSZip.utils.transformTo in GzipImporter

Rationale: It avoids OOM and improves speed of gzip import (see the
associated bug).

Note: Although still marked as experimental, TextDecoder has been
supported by Chrome since M38 (see
https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder#Browser_compatibility).

BUG=catapult:#2051

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b891575cc61cf38e90daa508697b453241d48f6f

[petrcermak, 2016-02-25 14:24:08]

petrcermak@chromium.org changed reviewers:
+ nduca@chromium.org, skyostil@chromium.org

[petrcermak, 2016-02-25 14:24:09]

Hi,

Please review this patch.

Thanks,
Petr

[petrcermak, 2016-02-25 14:25:21]

+cc sunnyps

[Sami, 2016-02-25 14:44:54]

https://codereview.chromium.org/1739663003/diff/1/tracing/tracing/extras/impo...
File tracing/tracing/extras/importer/gzip_importer.html (right):

https://codereview.chromium.org/1739663003/diff/1/tracing/tracing/extras/impo...
tracing/tracing/extras/importer/gzip_importer.html:132: var type =
JSZip.utils.getTypeOf(data);
Is it worth having a fallback to JSZip if TextDecoder isn't there?

[petrcermak, 2016-02-25 15:22:41]

Thanks for your comment. PTAL.

Petr

https://codereview.chromium.org/1739663003/diff/1/tracing/tracing/extras/impo...
File tracing/tracing/extras/importer/gzip_importer.html (right):

https://codereview.chromium.org/1739663003/diff/1/tracing/tracing/extras/impo...
tracing/tracing/extras/importer/gzip_importer.html:132: var type =
JSZip.utils.getTypeOf(data);
On 2016/02/25 14:44:54, Sami wrote:
> Is it worth having a fallback to JSZip if TextDecoder isn't there?

Done.

[Sami, 2016-02-25 15:33:53]

lgtm. Thanks for adding the test too.

[petrcermak, 2016-02-25 16:03:53]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:03:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739663003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739663003/20001

[commit-bot: I haz the power, 2016-02-25 16:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:14:29]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[petrcermak, 2016-02-25 16:15:02]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:15:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739663003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739663003/20001

[commit-bot: I haz the power, 2016-02-25 16:25:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:25:30]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[petrcermak, 2016-02-25 16:39:02]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-02-25 16:39:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1739663003/#ps40001
(title: "Don't access TextDecoder through 'window' (d8)")

[commit-bot: I haz the power, 2016-02-25 16:39:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739663003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739663003/40001

[commit-bot: I haz the power, 2016-02-25 16:50:47]

Description was changed from

==========
Use TextDecoder instead of JSZip.utils.transformTo in GzipImporter

Rationale: It avoids OOM and improves speed of gzip import (see the
associated bug).

Note: Although still marked as experimental, TextDecoder has been
supported by Chrome since M38 (see
https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder#Browser_compatib...).

BUG=catapult:#2051
==========

to

==========
Use TextDecoder instead of JSZip.utils.transformTo in GzipImporter

Rationale: It avoids OOM and improves speed of gzip import (see the
associated bug).

Note: Although still marked as experimental, TextDecoder has been
supported by Chrome since M38 (see
https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder#Browser_compatib...).

BUG=catapult:#2051

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-02-25 16:50:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...