Move GN directory name assert into //BUILD.gn

Move GN directory name assert into //BUILD.gn

This way it will be sure to be the first thing that fails, rather than
only sometimes.

BUG=548283
Committed: https://crrev.com/017b91f136d3d2d18b703bbeee63326423699676
Cr-Commit-Position: refs/heads/master@{#378255}

[agrieve, 2016-02-25 02:11:59]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org

[agrieve, 2016-02-25 02:12:00]

🔮

[brettw, 2016-02-25 22:30:14]

lgtm

https://codereview.chromium.org/1739603002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1739603002/diff/1/BUILD.gn#newcode29
BUILD.gn:29: # Because of the source assignment filter, many targets end up
over-filtering
Can you put this at the bottom so the file is more clear just reading from
top-to-bottom?

No other file will get loaded until this file is completed, so it won't hurt
your use-case, and we shouldn't have issues with targets in this file.

[agrieve, 2016-02-26 21:14:41]

https://codereview.chromium.org/1739603002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1739603002/diff/1/BUILD.gn#newcode29
BUILD.gn:29: # Because of the source assignment filter, many targets end up
over-filtering
On 2016/02/25 22:30:13, brettw wrote:
> Can you put this at the bottom so the file is more clear just reading from
> top-to-bottom?
> 
> No other file will get loaded until this file is completed, so it won't hurt
> your use-case, and we shouldn't have issues with targets in this file.

Moved to the bottom, but found out that setting an explicit source filter is
required on linux (so I added it). Without it, I'm seeing:

ERROR at //ppapi/native_client/BUILD.gn:48:3: Empty sources for copy command.
  copy("nacl_irt_debug") {
  ^-----------------------
You have to specify at least one file to copy in the "sources".

[brettw, 2016-02-26 21:30:19]

Okay, whatever. LGTM

[agrieve, 2016-02-29 18:21:51]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-02-29 18:22:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739603002/20001

[commit-bot: I haz the power, 2016-02-29 18:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 18:30:37]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[agrieve, 2016-02-29 19:21:51]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-02-29 19:22:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739603002/20001

[commit-bot: I haz the power, 2016-02-29 20:15:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-29 20:17:05]

Description was changed from

==========
Move GN directory name assert into //BUILD.gn

This way it will be sure to be the first thing that fails, rather than
only sometimes.

BUG=548283
==========

to

==========
Move GN directory name assert into //BUILD.gn

This way it will be sure to be the first thing that fails, rather than
only sometimes.

BUG=548283

Committed: https://crrev.com/017b91f136d3d2d18b703bbeee63326423699676
Cr-Commit-Position: refs/heads/master@{#378255}
==========

[commit-bot: I haz the power, 2016-02-29 20:17:06]

Patchset 2 (id:??) landed as
https://crrev.com/017b91f136d3d2d18b703bbeee63326423699676
Cr-Commit-Position: refs/heads/master@{#378255}