Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: BUILD.gn

Issue 1739603002: Move GN directory name assert into //BUILD.gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 855 matching lines...) Expand 10 before | Expand all | Expand 10 after
866 ] 866 ]
867 867
868 if (target_cpu == "x86") { 868 if (target_cpu == "x86") {
869 deps += [ "//chrome/tools/crash_service:crash_service_win64" ] 869 deps += [ "//chrome/tools/crash_service:crash_service_win64" ]
870 } 870 }
871 } else { 871 } else {
872 deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ] 872 deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
873 } 873 }
874 } 874 }
875 } 875 }
876
877 # Because of the source assignment filter, many targets end up over-filtering
878 # their sources if the output directory contains a platform name. Assert that
879 # this doesn't happen. http://crbug.com/548283
880 template("assert_valid_out_dir") {
881 # List copied from //build/config/BUILDCONFIG.gn.
882 set_sources_assignment_filter([
883 "*\bandroid/*",
884 "*\bchromeos/*",
885 "*\bcocoa/*",
886 "*\bios/*",
887 "*\blinux/*",
888 "*\bmac/*",
889 "*\bposix/*",
890 "*\bwin/*",
891 ])
892 assert(target_name != "") # Mark as used.
893 sources = invoker.actual_sources
894 assert(
895 sources == invoker.actual_sources,
896 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
897 }
898
899 assert_valid_out_dir("_unused") {
900 actual_sources = [ "$root_build_dir/foo" ]
901 }
OLDNEW
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698