Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1739593002: Revert "Move precompilation-related flags to flags list." (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Move precompilation-related flags to flags list." The default value of print_stop_message was architecture specific. TBR=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/bd85deaf4eabdb83f0adf242432ffd49535b6b59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -172 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/bin/main.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M runtime/lib/regexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/aot_optimizer.cc View 7 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M runtime/vm/block_scheduler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/code_descriptors.cc View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 3 chunks +12 lines, -1 line 0 comments Download
M runtime/vm/compiler.cc View 7 chunks +9 lines, -6 lines 0 comments Download
M runtime/vm/compiler_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/constant_propagator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 3 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/flag_list.h View 5 chunks +3 lines, -38 lines 0 comments Download
M runtime/vm/flags.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 7 chunks +65 lines, -54 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 2 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/native_arguments.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/pages.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 5 chunks +8 lines, -3 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/redundancy_elimination.cc View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/regexp.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/weak_code.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
rmacnak
Committed patchset #1 (id:1) manually as bd85deaf4eabdb83f0adf242432ffd49535b6b59 (presubmit successful).
4 years, 10 months ago (2016-02-25 02:08:08 UTC) #2
Florian Schneider
4 years, 10 months ago (2016-02-25 02:48:29 UTC) #3
Message was sent while issue was closed. 
Lgtm.

That's unfortunate. I'll make it platform-independent.

Powered by Google App Engine
This is Rietveld 408576698