Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Side by Side Diff: runtime/vm/weak_code.cc

Issue 1739593002: Revert "Move precompilation-related flags to flags list." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/stub_code_x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/weak_code.h" 5 #include "vm/weak_code.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 8
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
11 #include "vm/object.h" 11 #include "vm/object.h"
12 #include "vm/stack_frame.h" 12 #include "vm/stack_frame.h"
13 13
14 namespace dart { 14 namespace dart {
15 15
16 DECLARE_FLAG(bool, precompilation);
17
16 bool WeakCodeReferences::HasCodes() const { 18 bool WeakCodeReferences::HasCodes() const {
17 return !array_.IsNull() && (array_.Length() > 0); 19 return !array_.IsNull() && (array_.Length() > 0);
18 } 20 }
19 21
20 22
21 void WeakCodeReferences::Register(const Code& value) { 23 void WeakCodeReferences::Register(const Code& value) {
22 if (!array_.IsNull()) { 24 if (!array_.IsNull()) {
23 // Try to find and reuse cleared WeakProperty to avoid allocating new one. 25 // Try to find and reuse cleared WeakProperty to avoid allocating new one.
24 WeakProperty& weak_property = WeakProperty::Handle(); 26 WeakProperty& weak_property = WeakProperty::Handle();
25 for (intptr_t i = 0; i < array_.Length(); i++) { 27 for (intptr_t i = 0; i < array_.Length(); i++) {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 return false; 61 return false;
60 } 62 }
61 63
62 64
63 void WeakCodeReferences::DisableCode() { 65 void WeakCodeReferences::DisableCode() {
64 IncrementInvalidationGen(); 66 IncrementInvalidationGen();
65 const Array& code_objects = Array::Handle(array_.raw()); 67 const Array& code_objects = Array::Handle(array_.raw());
66 if (code_objects.IsNull()) { 68 if (code_objects.IsNull()) {
67 return; 69 return;
68 } 70 }
69 ASSERT(!FLAG_precompiled_mode); 71 ASSERT(!FLAG_precompilation);
70 UpdateArrayTo(Object::null_array()); 72 UpdateArrayTo(Object::null_array());
71 // Disable all code on stack. 73 // Disable all code on stack.
72 Code& code = Code::Handle(); 74 Code& code = Code::Handle();
73 { 75 {
74 DartFrameIterator iterator; 76 DartFrameIterator iterator;
75 StackFrame* frame = iterator.NextFrame(); 77 StackFrame* frame = iterator.NextFrame();
76 while (frame != NULL) { 78 while (frame != NULL) {
77 code = frame->LookupDartCode(); 79 code = frame->LookupDartCode();
78 if (IsOptimizedCode(code_objects, code)) { 80 if (IsOptimizedCode(code_objects, code)) {
79 ReportDeoptimization(code); 81 ReportDeoptimization(code);
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 // Make non-OSR code non-entrant. 128 // Make non-OSR code non-entrant.
127 if (!code.IsDisabled()) { 129 if (!code.IsDisabled()) {
128 ReportSwitchingCode(code); 130 ReportSwitchingCode(code);
129 code.DisableDartCode(); 131 code.DisableDartCode();
130 } 132 }
131 } 133 }
132 } 134 }
133 } 135 }
134 136
135 } // namespace dart 137 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/stub_code_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698