Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1739533005: [DevTools] Add touch to sensors view. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add touch to sensors view. Introduced MultitargetTouchModel along the way. BUG=584794 Committed: https://crrev.com/21eec9c0ffe1b01329957ff8d7819fabd7480eec Cr-Commit-Position: refs/heads/master@{#378125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -79 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 8 chunks +9 lines, -78 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js View 2 chunks +17 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js View 1 chunk +149 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/sensors.css View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 10 months ago (2016-02-26 03:13:19 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2016-02-27 04:11:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739533005/1
4 years, 10 months ago (2016-02-27 06:50:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-27 08:01:12 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-27 08:03:03 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/21eec9c0ffe1b01329957ff8d7819fabd7480eec
Cr-Commit-Position: refs/heads/master@{#378125}

Powered by Google App Engine
This is Rietveld 408576698