Issue 173943002: [Android WebView] Allow embedders to override text from scaling by system font scale.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173943002: [Android WebView] Allow embedders to override text from scaling by system font scale. (Closed)

Created:
6 years, 10 months ago by benm (inactive)

Modified:
6 years, 10 months ago

Reviewers:
mkosiba (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android WebView] Allow embedders to override text from scaling by system font scale. Relaxes the use of system font scale. Before this patch, we would override the value passed to AwSettings.setTextZoom to take into account system font scale. Now, if an app does not invoke setTextZoom then we'll respect the system font scale. However if an embedder then later invokes setTextZoom, we'll honor their value without applying any scale. BUG=345294 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252347

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	android_webview/java/src/org/chromium/android_webview/AwSettings.java	View		3 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/173943002/1

6 years, 10 months ago (2014-02-20 16:45:36 UTC) #4

Message was sent while issue was closed.

Change committed as 252347

Expand Messages | Collapse Messages